Skip to content

[monitoring] Add OpenTelemetry spans in scd/datastore/subscriptions #1367

Closed
the-glu wants to merge 3 commits intointeruss:masterfrom
Orbitalize:opentelemetry_scd_datastore
Closed

[monitoring] Add OpenTelemetry spans in scd/datastore/subscriptions #1367
the-glu wants to merge 3 commits intointeruss:masterfrom
Orbitalize:opentelemetry_scd_datastore

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Jan 29, 2026

This is a set of 3 PRs, proposition to add OpenTelemetry to generate optional traces.
You can check the base PR, the one for handlers and the one for datastores.

This PR add as an example spans in pkg/scd/store/datastore/subscriptions.go

Spans look like that:

image_2026-01-29_12-51-52

Idea would be to have that in all datastores operations (that have the context).

Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7f9fcec
Same as for #1366: it is quite noisy to have all those additional calls in every single function. It is also error-prone as in the future it is too easy to miss adding some.

IMO we should not need to trace internal functions. Here since we have an interface Subscription we could have a tracing interface wrapping this one.
Also rather than hardcoding the name of the function manually we could be using reflect to get the function's name.

@the-glu
Copy link
Contributor Author

the-glu commented Mar 11, 2026

Same as #1366 let close that one for now, and if possible add if we have a better store ^^'

@the-glu the-glu closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants