Skip to content

fix: restore main CI after exact-format reader refactor - #8231

Merged
Xuanwo merged 2 commits into
mainfrom
xuanwo/fix-main-ci-reader-projection
Aug 4, 2026
Merged

fix: restore main CI after exact-format reader refactor#8231
Xuanwo merged 2 commits into
mainfrom
xuanwo/fix-main-ci-reader-projection

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Why

Main CI broke after #8024 landed: ReaderProjection::from_column_names / from_whole_schema were removed, but IVF index call sites still used them, so Rust, Java JNI, and Python builds failed to compile.

Separately, newly published RUSTSEC advisories caused cargo-deny to fail on unpinned transitive crates.

What

  • Switch remaining IVF readers/tests to lance_file::versions::reader_projection_from_*
  • Bump fixable transitive deps (anyhow, event-listener, memmap2, rkyv, spin) in all three lockfiles
  • Ignore RUSTSEC-2026-0002 for lru 0.12.x until goosefs-sdk upgrades

PR #8024 removed ReaderProjection::from_column_names/from_whole_schema.
Update remaining IVF call sites to the versioned free functions, and
bump transitive deps for newly published RUSTSEC advisories.
@github-actions github-actions Bot added A-python Python bindings A-java Java bindings + JNI A-deps Dependency updates bug Something isn't working labels Aug 4, 2026
Tests added with the exact-format reader refactor referenced
LanceFileVersion without importing it, breaking lib-test builds.
@github-actions github-actions Bot added the A-encoding Encoding, IO, file reader/writer label Aug 4, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Gate recommendation: approve with a non-blocking risk.

The compile repair uses the runtime version dispatcher and passes locked Rust, Python, and JNI builds plus both focused HNSW projection tests. The remaining risk is lru 0.12.5: it is constrained by the latest goosefs-sdk and its current source does not use the affected IterMut API, so the documented ignore is reasonable for this repair, but upgrading goosefs-sdk should remain the follow-up.

@Xuanwo
Xuanwo merged commit 5790539 into main Aug 4, 2026
39 checks passed
@Xuanwo
Xuanwo deleted the xuanwo/fix-main-ci-reader-projection branch August 4, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-deps Dependency updates A-encoding Encoding, IO, file reader/writer A-java Java bindings + JNI A-python Python bindings bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants