fix: restore main CI after exact-format reader refactor - #8231
Merged
Conversation
PR #8024 removed ReaderProjection::from_column_names/from_whole_schema. Update remaining IVF call sites to the versioned free functions, and bump transitive deps for newly published RUSTSEC advisories.
BubbleCal
approved these changes
Aug 4, 2026
Tests added with the exact-format reader refactor referenced LanceFileVersion without importing it, breaking lib-test builds.
Contributor
There was a problem hiding this comment.
The compile repair uses the runtime version dispatcher and passes locked Rust, Python, and JNI builds plus both focused HNSW projection tests. The remaining risk is lru 0.12.5: it is constrained by the latest goosefs-sdk and its current source does not use the affected IterMut API, so the documented ignore is reasonable for this repair, but upgrading goosefs-sdk should remain the follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Main CI broke after #8024 landed:
ReaderProjection::from_column_names/from_whole_schemawere removed, but IVF index call sites still used them, so Rust, Java JNI, and Python builds failed to compile.Separately, newly published RUSTSEC advisories caused
cargo-denyto fail on unpinned transitive crates.What
lance_file::versions::reader_projection_from_*anyhow,event-listener,memmap2,rkyv,spin) in all three lockfilesRUSTSEC-2026-0002forlru0.12.x untilgoosefs-sdkupgrades