Skip to content

fix: restore main CI after exact-format reader refactor #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 2 commits into from
Aug 4, 2026
Merged

fix: restore main CI after exact-format reader refactor #8231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff80462
fix: update ReaderProjection callers after exact-format refactor
Xuanwo Aug 4, 2026
8fa195c
fix(file): import LanceFileVersion in reader tests
Xuanwo Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ ignore = [
{ id = "RUSTSEC-2025-0119", reason = "`number_prefix` used by hf-hub in examples" },
{ id = "RUSTSEC-2026-0194", reason = "`quick-xml` <0.41 pulled transitively via object_store (datafusion) and reqsign-aws-v4 (opendal); upstream must upgrade first" },
{ id = "RUSTSEC-2026-0195", reason = "`quick-xml` <0.41 pulled transitively via object_store (datafusion) and reqsign-aws-v4 (opendal); upstream must upgrade first" },
{ id = "RUSTSEC-2026-0002", reason = "`lru` 0.12.x pulled transitively via goosefs-sdk; fixed in >=0.16.3, goosefs-sdk must upgrade first" },
]
# If this is true, then cargo deny will use the git executable to fetch advisory database.
# If this is false, then it uses a built-in git library.
Expand Down
15 changes: 7 additions & 8 deletions java/lance-jni/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 14 additions & 15 deletions python/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/lance-file/src/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,7 +2371,7 @@ mod tests {
EncodedBatchReaderExt, FileReader, FileReaderOptions, ProjectedFileReader, ReaderProjection,
};
use crate::testing::{FsFixture, WrittenFile, test_cache, write_lance_file};
use crate::version::ConcreteFileVersion;
use crate::version::{ConcreteFileVersion, LanceFileVersion};
use crate::versions;
use crate::writer::FileWriterOptions;
use lance_encoding::decoder::DecoderConfig;
Expand Down
6 changes: 3 additions & 3 deletions rust/lance/src/index/vector/ivf/v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ impl<S: IvfSubIndex + 'static, Q: Quantization> IVFIndex<S, Q> {
fn read_projection(reader: &FileReader) -> Result<Option<ReaderProjection>> {
S::read_columns()
.map(|columns| {
ReaderProjection::from_column_names(
lance_file::versions::reader_projection_from_column_names(
reader.metadata().version(),
reader.schema(),
columns,
Expand Down Expand Up @@ -4929,7 +4929,7 @@ mod tests {
// Projected first on purpose: it then pays any first-touch metadata
// cost, so the comparison understates rather than flatters the saving.
let projected_bytes = read_bytes_for(projection.clone()).await;
let full_bytes = read_bytes_for(lance_file::reader::ReaderProjection::from_whole_schema(
let full_bytes = read_bytes_for(lance_file::versions::reader_projection_from_whole_schema(
hnsw.reader.schema(),
hnsw.reader.metadata().version(),
))
Expand Down Expand Up @@ -4988,7 +4988,7 @@ mod tests {
continue;
}
let full = read_range(
lance_file::reader::ReaderProjection::from_whole_schema(
lance_file::versions::reader_projection_from_whole_schema(
hnsw.reader.schema(),
hnsw.reader.metadata().version(),
),
Expand Down
Loading