Fix websocket close code validation #673
Open
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blood-worm
force-pushed
the
fix/websocket-close-code-validation
branch
from
83c2caa to
7c852e1
Compare
6 tasks
|
No, this does not fix it. Ended with: Failed to WS_SEND, curl: (100) Recv failure: Connection reset by peer. See https://curl.se/libcurl/c/libcurl-errors.html first for more details. |
Author
This is not meant to fix exceptions related to network errors, it is meant to fix an exception raised in a completely valid websocket state where the websocket is closed with a custom close code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the websocket close code validation to be less strict. Closes #672.