Skip to content

Fix websocket close code validation #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blood-worm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix websocket close code validation #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions curl_cffi/requests/websockets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,7 @@ def _unpack_close_frame(frame: bytes) -> tuple[int, str]:
"Invalid close frame", WsCloseCode.PROTOCOL_ERROR
) from e
else:
if (
code not in WsCloseCode._value2member_map_
or code == WsCloseCode.UNKNOWN
):
if code == WsCloseCode.UNKNOWN or code < 1000 or code >= 5000:
raise WebSocketError(
f"Invalid close code: {code}", WsCloseCode.PROTOCOL_ERROR
)
Expand Down