RuntimeLibcalls: Add mustprogress to common function attributes #167080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
added
llvm:ir
llvm:SelectionDAG
Graphite App
arsenm
requested review from
MacDue,
RKSimon,
aemerson,
dpaoliello,
efriedma-quic,
fhahn,
ilovepi,
inbelic,
mysterymath,
nikic,
paulwalker-arm and
topperc
This was referenced Nov 8, 2025
This was referenced Nov 8, 2025
Contributor
Author
This was referenced Nov 8, 2025
This was referenced Nov 8, 2025
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-memcpy-memmove-memset-chk-functions
branch
from
31b8490 to
e551019
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-mustprogress-common-fn-attrs
branch
from
47b2103 to
238ad7d
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-memcpy-memmove-memset-chk-functions
branch
from
e551019 to
9b770d3
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-mustprogress-common-fn-attrs
branch
2 times, most recently
from
ad1d7cb to
b7cc28e
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-memcpy-memmove-memset-chk-functions
branch
from
9b770d3 to
abbd23c
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-mustprogress-common-fn-attrs
branch
from
b7cc28e to
ddc5a54
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-memcpy-memmove-memset-chk-functions
branch
from
06269dd to
abf1fe1
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-mustprogress-common-fn-attrs
branch
from
ddc5a54 to
22df2fb
Compare
Contributor
Author
|
ping |
RKSimon
approved these changes
Nov 22, 2025
Collaborator
RKSimon
left a comment
RKSimon
left a comment
There was a problem hiding this comment.
LGTM - but I don't know all the idiosyncrasies of mustprogress tbh, but the language reference suggests this should be fine.
These are floating-point functions recorded in TargetLibraryInfo, but missing from RuntimeLibcalls.
These were in TargetLibraryInfo, but missing from RuntimeLibcalls. This only adds the cases that already have the non-chk variants already. Copies the enabled-by-default logic from TargetLibraryInfo, which is probably overly permissive. Only isPS opts-out.
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-mustprogress-common-fn-attrs
branch
from
22df2fb to
a921be6
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/add-memcpy-memmove-memset-chk-functions
branch
from
abf1fe1 to
65e64a8
Compare
Base automatically changed from
users/arsenm/runtime-libcalls/add-memcpy-memmove-memset-chk-functions
to
main
November 25, 2025 14:39
arsenm
deleted the
users/arsenm/runtime-libcalls/add-mustprogress-common-fn-attrs
branch
Contributor
|
I'm confused by this change -- why are we adding mustprogress? For intrinsics |
Contributor
Author
These aren't intrinsics, they're libcall function declarations? |
Contributor
Same thing. The purpose of mustprogress is to allow inferring willreturn. It is not useful for declarations that are willreturn anyway. The PR has no description, can you please explain what the motivation here was? |
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.