RuntimeLibcalls: Add memset_pattern* calls to darwin systems #167083

arsenm · 2025-11-08T03:29:01Z

This is one of the easier cases to comprehend in TargetLibraryInfo's
setup.

arsenm · 2025-11-08T03:29:27Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

fhahn

LGTM, thanks

Calloc was already here, but not the others. Also add manual type information.

Script scraped dump of most functions in TargetLibraryInfo.def, with existing entries and a few special cases removed. This only adds the definitions, and doesn't add them to any system yet. Adding them in the correct places is the hard part, since it's all written as opt-out with manually written exemptions in TargetLibraryInfo.

This is one of the easier cases to comprehend in TargetLibraryInfo's setup.

llvm-ci · 2025-11-26T18:05:44Z

LLVM Buildbot has detected a new failure on builder reverse-iteration running on hexagon-build-03 while building llvm at step 6 "check_all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/110/builds/6515

Here is the relevant piece of the build log for the reference

Step 6 (check_all) failure: test (failure)
******************** TEST 'Clang :: Interpreter/cxx20-modules.cppm' FAILED ********************
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 3
rm -rf /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp
# executed command: rm -rf /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp
# RUN: at line 4
mkdir -p /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp
# executed command: mkdir -p /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp
# RUN: at line 5
split-file /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.src/clang/test/Interpreter/cxx20-modules.cppm /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp
# executed command: split-file /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.src/clang/test/Interpreter/cxx20-modules.cppm /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp
# RUN: at line 7
/local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang -std=c++20 /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.cppm --precompile      -o /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.pcm --target=x86_64-linux-gnu
# executed command: /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang -std=c++20 /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.cppm --precompile -o /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.pcm --target=x86_64-linux-gnu
# RUN: at line 9
/local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang -fPIC /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.pcm -c -o /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.o --target=x86_64-linux-gnu
# executed command: /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang -fPIC /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.pcm -c -o /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.o --target=x86_64-linux-gnu
# RUN: at line 10
/local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang -nostdlib -fPIC -shared /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.o -o /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/libmod.so --target=x86_64-linux-gnu
# executed command: /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang -nostdlib -fPIC -shared /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.o -o /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/libmod.so --target=x86_64-linux-gnu
# RUN: at line 12
cat /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/import.cpp | env LD_LIBRARY_PATH=/local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp:$LD_LIBRARY_PATH      /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang-repl -Xcc=-std=c++20 -Xcc=-fmodule-file=M=/local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.pcm      -Xcc=--target=x86_64-linux-gnu | /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/FileCheck /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/import.cpp
# executed command: cat /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/import.cpp
# .---command stdout------------
# | 
# | %lib libmod.so
# | 
# | import M;
# | 
# | extern "C" int printf(const char *, ...);
# | printf("%s\n", Hello());
# | 
# | // CHECK: Hello Interpreter for Modules!
# `-----------------------------
# executed command: env 'LD_LIBRARY_PATH=/local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp:$LD_LIBRARY_PATH' /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang-repl -Xcc=-std=c++20 -Xcc=-fmodule-file=M=/local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/mod.pcm -Xcc=--target=x86_64-linux-gnu
# .---command stderr------------
# | /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/clang-repl: error while loading shared libraries: libc++.so.1: cannot open shared object file: No such file or directory
# `-----------------------------
# error: command failed with exit status: 127
# executed command: /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/FileCheck /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/import.cpp
# .---command stderr------------
# | FileCheck error: '<stdin>' is empty.
# | FileCheck command line:  /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/bin/FileCheck /local/mnt/workspace/bots/hexagon-build-03/reverse-iteration/llvm.obj/tools/clang/test/Interpreter/Output/cxx20-modules.cppm.tmp/import.cpp
# `-----------------------------
# error: command failed with exit status: 2

--
...

…7083) This is one of the easier cases to comprehend in TargetLibraryInfo's setup.

arsenm mentioned this pull request Nov 8, 2025

RuntimeLibcalls: Add more function entries from TargetLibraryInfo #167082

Merged

arsenm added llvm:ir llvm:SelectionDAG SelectionDAGISel as well llvm:transforms labels Nov 8, 2025 — with Graphite App

arsenm requested review from MacDue, RKSimon, aemerson, dpaoliello, efriedma-quic, fhahn, ilovepi, inbelic, mysterymath, nikic and paulwalker-arm November 8, 2025 03:29

This was referenced Nov 8, 2025

RuntimeLibcalls: Add small_printf functions to emscripten #167087

Merged

XCore: Add iprintf to RuntimeLibcalls system library #167088

Merged

PowerPC: Add vec_malloc functions to AIX in RuntimeLibcalls #167089

Merged

arsenm force-pushed the users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo branch from 06d0094 to a25d7fe Compare November 10, 2025 18:18

arsenm force-pushed the users/arsenm/runtime-libcalls/add-memset-pattern-darwin branch from 640cf80 to 6ee0ec3 Compare November 10, 2025 18:18

arsenm force-pushed the users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo branch from a25d7fe to 61c70b5 Compare November 10, 2025 19:22

arsenm force-pushed the users/arsenm/runtime-libcalls/add-memset-pattern-darwin branch 2 times, most recently from 28d3aa9 to abfd3b2 Compare November 12, 2025 00:57

arsenm force-pushed the users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo branch from 61c70b5 to d787eb1 Compare November 12, 2025 00:57

arsenm force-pushed the users/arsenm/runtime-libcalls/add-memset-pattern-darwin branch from abfd3b2 to 9150bc5 Compare November 12, 2025 02:11

arsenm force-pushed the users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo branch from d787eb1 to 5c9ed73 Compare November 12, 2025 02:11

arsenm force-pushed the users/arsenm/runtime-libcalls/add-memset-pattern-darwin branch from 9150bc5 to 4ab6bb5 Compare November 12, 2025 03:24

arsenm force-pushed the users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo branch from 5c9ed73 to 03dc81d Compare November 12, 2025 03:24

aemerson approved these changes Nov 12, 2025

View reviewed changes

fhahn approved these changes Nov 12, 2025

View reviewed changes

arsenm force-pushed the users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo branch from 03dc81d to ac9be6e Compare November 25, 2025 13:43

arsenm force-pushed the users/arsenm/runtime-libcalls/add-memset-pattern-darwin branch from 4ab6bb5 to 9682a52 Compare November 25, 2025 13:43

arsenm added 3 commits November 25, 2025 11:17

RuntimeLibcalls: Add malloc and free entries

89e79ea

Calloc was already here, but not the others. Also add manual type information.

RuntimeLibcalls: Add memset_pattern* calls to darwin systems

d668db8

This is one of the easier cases to comprehend in TargetLibraryInfo's setup.

arsenm force-pushed the users/arsenm/runtime-libcalls/add-memset-pattern-darwin branch from 9682a52 to d668db8 Compare November 25, 2025 16:18

arsenm force-pushed the users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo branch from ac9be6e to 12b2b36 Compare November 25, 2025 16:18

Base automatically changed from users/arsenm/runtime-libcalls/add-more-entries-from-targetlibraryinfo to main November 26, 2025 15:19

arsenm merged commit 9e1d3ca into main Nov 26, 2025
13 of 17 checks passed

arsenm deleted the users/arsenm/runtime-libcalls/add-memset-pattern-darwin branch November 26, 2025 15:36

tanji-dg pushed a commit to tanji-dg/llvm-project that referenced this pull request Nov 27, 2025

RuntimeLibcalls: Add memset_pattern* calls to darwin systems (llvm#16…

c8865b9

…7083) This is one of the easier cases to comprehend in TargetLibraryInfo's setup.

GeneraluseAI pushed a commit to GeneraluseAI/llvm-project that referenced this pull request Nov 27, 2025

RuntimeLibcalls: Add memset_pattern* calls to darwin systems (llvm#16…

6f0158e

…7083) This is one of the easier cases to comprehend in TargetLibraryInfo's setup.

augusto2112 pushed a commit to augusto2112/llvm-project that referenced this pull request Dec 3, 2025

RuntimeLibcalls: Add memset_pattern* calls to darwin systems (llvm#16…

8bcf51f

…7083) This is one of the easier cases to comprehend in TargetLibraryInfo's setup.

kcloudy0717 pushed a commit to kcloudy0717/llvm-project that referenced this pull request Dec 4, 2025

RuntimeLibcalls: Add memset_pattern* calls to darwin systems (llvm#16…

a952f1f

…7083) This is one of the easier cases to comprehend in TargetLibraryInfo's setup.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RuntimeLibcalls: Add memset_pattern* calls to darwin systems #167083

RuntimeLibcalls: Add memset_pattern* calls to darwin systems #167083

Uh oh!

arsenm commented Nov 8, 2025

Uh oh!

arsenm commented Nov 8, 2025 •

edited

Loading

Uh oh!

fhahn left a comment

Uh oh!

Uh oh!

llvm-ci commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RuntimeLibcalls: Add memset_pattern* calls to darwin systems #167083

RuntimeLibcalls: Add memset_pattern* calls to darwin systems #167083

Uh oh!

Conversation

arsenm commented Nov 8, 2025

Uh oh!

arsenm commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fhahn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

llvm-ci commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

arsenm commented Nov 8, 2025 •

edited

Loading