Optimize quarter column computation using vectorized NumPy operations#1065
Open
vshnvii wants to merge 2 commits intomalariagen:masterfrom
Open
Optimize quarter column computation using vectorized NumPy operations#1065vshnvii wants to merge 2 commits intomalariagen:masterfrom
vshnvii wants to merge 2 commits intomalariagen:masterfrom
Conversation
Author
|
Hello @jonbrenas @leehart I'm exploring the repository to start contributing towards GSoC 2026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the row-wise pandas "apply()" used to compute the "quarter"
column with a vectorized NumPy implementation.
Previous implementation:
df["quarter"] = df.apply(
lambda row: ((row.month - 1) // 3) + 1 if row.month > 0 else -1,
axis="columns",
)
Row-wise "apply()" loops through rows in Python and can be slow for large datasets.
The new implementation uses NumPy vectorization:
df["quarter"] = np.where(
df["month"] > 0,
((df["month"] - 1) // 3) + 1,
-1
)
This improves performance and follows pandas best practices.