Skip to content

fix: use is not None for region boundary checks in _subset_genome_sequence_region #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Carbon14-48 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use is not None for region boundary checks in _subset_genome_sequence_region #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions malariagen_data/plasmodium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,17 +232,17 @@ def _resolve_region(self, region):
def _subset_genome_sequence_region(
self, genome, region, inline_array=True, chunks="native"
):
"""Sebset reference genome sequence."""
"""Subset reference genome sequence."""
region = self._resolve_region(region)
z = genome[region.contig]

d = _da_from_zarr(z, inline_array=inline_array, chunks=chunks)

if region.start:
if region.start is not None:
slice_start = region.start - 1
else:
slice_start = None
if region.end:
if region.end is not None:
slice_stop = region.end
else:
slice_stop = None
Expand Down