docs: expand documentation for sample_metadata()#933
Open
Tanisha127 wants to merge 9 commits intomalariagen:masterfrom
Open
docs: expand documentation for sample_metadata()#933Tanisha127 wants to merge 9 commits intomalariagen:masterfrom
Tanisha127 wants to merge 9 commits intomalariagen:masterfrom
Conversation
Contributor
Author
|
Hi @jonbrenas and @ahernank, I’ve opened PR #933 to expand the documentation for Thank you! |
Contributor
Author
|
Hi @jonbrenas , |
jonbrenas
requested changes
Mar 7, 2026
Collaborator
jonbrenas
left a comment
There was a problem hiding this comment.
The "summary" and "returns" are good, the "parameters" are read from base_params and are thus already described elsewhere, so they are not needed here.
Contributor
Author
|
Hi @jonbrenas, I've removed the parameters section as requested — only summary and returns remain. Could you please take another look when convenient? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the documentation for
sample_metadata()to provide:Fixes #553.