Skip to content

docs: expand documentation for sample_metadata()#933

Open
Tanisha127 wants to merge 9 commits intomalariagen:masterfrom
Tanisha127:improve-sample-metadata-docs
Open

docs: expand documentation for sample_metadata()#933
Tanisha127 wants to merge 9 commits intomalariagen:masterfrom
Tanisha127:improve-sample-metadata-docs

Conversation

@Tanisha127
Copy link
Contributor

This PR expands the documentation for sample_metadata() to provide:

  • A clearer summary of how metadata is assembled
  • Detailed parameter descriptions
  • An expanded description of the returned DataFrame
  • Explanation of merged metadata sources (general metadata, QC metadata, surveillance flags, AIM, cohorts)

Fixes #553.

@Tanisha127
Copy link
Contributor Author

Hi @jonbrenas and @ahernank,

I’ve opened PR #933 to expand the documentation for sample_metadata().
I’d appreciate your feedback when you have time.
Also, the workflows are awaiting maintainer approval for CI to run.

Thank you!

@Tanisha127
Copy link
Contributor Author

Hi @jonbrenas ,
All checks are now passing for this PR. Could you please review it when convenient?
Happy to make any changes if needed.
Thank you!

Copy link
Collaborator

@jonbrenas jonbrenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "summary" and "returns" are good, the "parameters" are read from base_params and are thus already described elsewhere, so they are not needed here.

@Tanisha127 Tanisha127 requested a review from jonbrenas March 8, 2026 05:03
@Tanisha127
Copy link
Contributor Author

Hi @jonbrenas, I've removed the parameters section as requested — only summary and returns remain. Could you please take another look when convenient? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding more documentation for sample set metadata

2 participants