Repository navigation
Remove --exclude-fields from search forward and search category - #79
Merged
Merged
Conversation
photos and reviews are only returned for accounts with a specific data provider arrangement, so for everyone else the flag has no effect. Say so in the spec and in docs/commands.md rather than implying the fields are always there to exclude.
The photos and reviews fields it omitted are only returned for accounts with a specific data provider arrangement, so for everyone else the flag never had an effect. Drop it rather than document a parameter that does nothing for most users.
zmofei
changed the title
mattpodwysocki
approved these changes
Oct 5, 2026
mattpodwysocki
left a comment
mattpodwysocki
left a comment
Contributor
There was a problem hiding this comment.
Built it and confirmed directly: --exclude-fields is gone from --help, and using it now fails with unexpected argument at exit code 2, matching the changelog. Full suite, fmt, clippy -D warnings, and docs_contract all clean. Small, surgical fix for a real no-op flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--exclude-fieldsonsearch forwardandsearch categoryadvertisedphotosandreviewsas fields you can omit, but those fields are only returned for accounts with a specific data provider arrangement. For everyone else they never appear, so the flag did nothing.This removes the parameter from the search spec and from
docs/commands.md. Removing a flag is breaking, so there is a Breaking changelog entry: a script that passes--exclude-fieldsnow fails with a usage error (exit 2) and should drop the flag.Fixes #77
Not checked: I did not test against an account that has that arrangement.