Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Add ability to update json files#55

Merged
seanbudd merged 11 commits into
nvaccess:mainfrom
nvdaes:regeneratejson
Jan 27, 2026
Merged

Add ability to update json files#55
seanbudd merged 11 commits into
nvaccess:mainfrom
nvdaes:regeneratejson

Conversation

@nvdaes

@nvdaes nvdaes commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

@seanbudd

Copy link
Copy Markdown
Member

@nvdaes do you plan on working this still?

@nvdaes

nvdaes commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

Sean wrote:

do you plan on working this still?

Yes @seanbudd. I think that this may be ready for review. I stopped working on this temporarily since I thought that you are busy preparing NVDA 2026.1. If you think that more work should be done on this, let me know. Otherwise, I can perform some tests this weekend.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes - can you prepare a matching PR to addon-datastore to make sure the file name change is handled?

Comment thread errors.md Outdated
@@ -0,0 +1,4 @@
""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file

@seanbudd seanbudd marked this pull request as ready for review January 23, 2026 05:03
@nvdaes

nvdaes commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Sean weote:

can you prepare a matching PR to addon-datastore to make sure the file name change is handled?

Yes. Please let me know if we should change the name in all possible files, for example also renaming regenerateTranslations.bat in this repo, and the workflow and jobs in addon-datastore.

@seanbudd

Copy link
Copy Markdown
Member

yes, if we are changing the python file, lets change the rest to match

@seanbudd seanbudd merged commit e146e63 into nvaccess:main Jan 27, 2026
2 checks passed
This was referenced Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants