cgroups: Fix eBPF program leaks#5322
Open
rata wants to merge 3 commits into
Open
Conversation
rata
force-pushed
the
fix-ebpf-leak
branch
3 times, most recently
from
81f81a9 to
95244d6
Compare
Member
Author
|
Created this to consider moving the mock to the cgroup repo: opencontainers/cgroups#61 |
This new version includes fixes for EPBF fd leaks: opencontainers/cgroups#60 Let's update to it. However, the Stats() method was added in the new release to the interface, so tests were failing with: # github.com/opencontainers/runc/libcontainer [github.com/opencontainers/runc/libcontainer.test] ./container_linux_test.go:125:18: cannot use &mockCgroupManager{…} (value of type *mockCgroupManager) as cgroups.Manager value in struct literal: *mockCgroupManager does not implement cgroups.Manager (missing method Stats) Let's add the method to the mock too. In the future, probably the mock should come from the cgroups module. Signed-off-by: Rodrigo Campos <rodrigo@amutable.com>
Now the cgroups dependency has been upgraded and it doesn't cause these leaks anymore. Let's remove the exclude. Signed-off-by: Rodrigo Campos <rodrigo@amutable.com>
Member
Author
|
I guess this should have a changelog entry, saying the leak was fixed. |
Signed-off-by: Rodrigo Campos <rodrigo@amutable.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new version of the cgroups dependency (v0.0.7) includes fixes for eBPF program leaks. They were fixed in this PR (from Argentina, with love :-P): opencontainers/cgroups#60
Let's update to that version and not exclude any fd from leaks :)
Please note that the cgroups module added a method to an interface, that we needed to add to a mock so tests compile. I put it in the same commit as the upgrade itself so we don't break bisect unnecessarily.