feat: amend new fields to interval schema#317
Open
project-defiant wants to merge 4 commits intomasterfrom
Open
feat: amend new fields to interval schema#317project-defiant wants to merge 4 commits intomasterfrom
project-defiant wants to merge 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds two new fields to the Interval schema to enhance genomic interval data representation: biosampleFromSourceId to capture the original biosample identifier from data sources, and qualityControls to store quality control flags.
Changes:
- Added
biosampleFromSourceIdfield to store the original biosample identifier as defined by datasource providers - Added
qualityControlsfield to track quality control flags for interval data - Updated both the entity model and GraphQL schema definitions to maintain consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/models/entities/Intervals.scala | Added two new required fields to the Interval case class: biosampleFromSourceId (String) and qualityControls (Vector[String]) |
| app/models/gql/Objects.scala | Added corresponding GraphQL DocumentField definitions for the new fields with appropriate descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR adds the new fields
biosampleFromSourceIdqualityControlsto the Intervals dataset.