fix(ui): improve dashboard widget edit controls#17359
Open
JarrodMFlesch wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves modular dashboard widget edit controls by relying on shared
Buttonstyling for the edit, delete, and width controls.The widget edit state now dims the widget content with a focus outline, and keeps that overlay active while the width popup is open so portaled popup content remains visually associated with its widget. The width popup trigger uses
renderButton, and the edit icon 24px path now matches the 16pxEditIconorientation instead of the previous rotated path.Related:
EditIconpath.--color-bg-brand-secondary.Verified with:
pnpm exec eslint packages/ui/src/icons/Edit/index.tsx packages/ui/src/views/Dashboard/Default/ModularDashboard/WidgetEditControl.tsx packages/ui/src/views/Dashboard/Default/ModularDashboard/index.client.tsxpnpm exec vitest run --project unit packages/ui/src/icons/Edit/index.spec.tsNote:
lint-pr-title "fix(ui): improve dashboard widget edit controls"was skipped becauselint-pr-titleis not installed in this environment.