Fix debugOptimized DevSettingsActivity manifest#57406
Conversation
|
Additional context: this crash is more noticeable in
This PR only fixes the |
| @@ -0,0 +1,21 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | |||
|
|
|||
There was a problem hiding this comment.
Can you add a comment explaining why this manifest is needed and that it hsould be kept in sync with the devsupport one?
There was a problem hiding this comment.
Hi, I added a comment. I kept this manifest aligned with the debug DevSupport manifest because debugOptimized still enables DevSupport/Dev Menu while using optimized native code, so debug-only DevSupport entries such as DevSettingsActivity and the legacy FPS overlay permission should remain available.
debugOptimized keeps JS debugging and DevSupport enabled while using optimized native code, but it did not include the debug DevSupport manifest entries. This caused the Dev Menu Settings action to crash because DevSettingsActivity was not declared for debugOptimized builds. Keeping the debugOptimized manifest in sync with the debug DevSupport manifest also preserves other debug-only DevSupport entries such as the legacy FPS overlay permission.
1d19fdf to
2ac576c
Compare
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D110463462. |
|
@cortinico merged this pull request in 2fb4f13. |
Summary:
Fixes #57396.
debugOptimizedbuilds still expose the React Native Dev MenuSettingsitem, butDevSettingsActivitywas only declared in thedebugmanifest. This causedSettingsto crash indebugOptimizedwithActivityNotFoundException.This adds a
debugOptimizedmanifest matching the existing debug dev-support manifest, soDevSettingsActivityis declared for that build type.Changelog:
[ANDROID] [FIXED] - Fix Dev Menu Settings crash in debugOptimized builds
Test Plan:
Verified with RNTester debugOptimized:
then shake and tap
Settings, confirm that Debug Settings opens instead of crashing.