Skip to content

Fix debugOptimized DevSettingsActivity manifest #57406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Phecda wants to merge 1 commit into from
+22 −0
Closed

Fix debugOptimized DevSettingsActivity manifest #57406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/react-native/ReactAndroid/src/debugOptimized/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

@cortinico cortinico Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why this manifest is needed and that it hsould be kept in sync with the devsupport one?

@Phecda Phecda Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I added a comment. I kept this manifest aligned with the debug DevSupport manifest because debugOptimized still enables DevSupport/Dev Menu while using optimized native code, so debug-only DevSupport entries such as DevSettingsActivity and the legacy FPS overlay permission should remain available.

<!--
debugOptimized keeps JS debugging and DevSupport enabled while using
optimized native code. Keep this manifest in sync with the debug
DevSupport manifest so debug-only DevSupport components remain available.
-->
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>

<!--
On Android 17 (SDK 37) devices, apps that declare this must hold ACCESS_LOCAL_NETWORK
to reach the dev server over the local network. Loopback via `adb reverse` is exempt.
-->
<uses-permission android:name="android.permission.ACCESS_LOCAL_NETWORK"/>

<application>
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity"
android:exported="false" />
</application>

</manifest>
Loading