Return TokenizationError instead of panicking on invalid content metadata length - #500
Open
RUKAYAT-CODER wants to merge 1 commit into
Open
Conversation
…data length mint() used .unwrap() on BytesValidator::validate_length() for title, description, and content_hash, so an out-of-range value (e.g. a content_hash that isn't exactly 32 bytes) panicked the whole invocation instead of returning a recoverable contract error. Propagate TokenizationError::InvalidMetadata via ? instead. Closes rinafcode#485
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContentTokenization::mint(contracts/teachlink/src/tokenization.rs) used.unwrap()onBytesValidator::validate_length()fortitle,description, andcontent_hash. An out-of-range value — most notably acontent_hashthat isn't exactly 32 bytes — panicked the entire contract invocation (HostError: Error(WasmVm, InvalidAction)) instead of returning a recoverableResult::Err.Fix
Replaced the three
.unwrap()calls with.map_err(|_| TokenizationError::InvalidMetadata)?, so callers now get a normal contract error instead of the invocation panicking.mint's enclosing closure already returnsTokenizationResult<u64>, so this propagates cleanly through the existingreentrancy::with_guardwrapper.Closes #485