Skip to content

Return TokenizationError instead of panicking on invalid content metadata length #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RUKAYAT-CODER wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return TokenizationError instead of panicking on invalid content metadata length #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions contracts/teachlink/src/tokenization.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,14 @@ impl ContentTokenization {
crate::validation::AddressValidator::validate(env, &creator).unwrap();

// Metadata validation (if title/description were String, we'd use StringValidator)
// Since they are Bytes, we check length
crate::validation::BytesValidator::validate_length(&title, 1, 100).unwrap();
crate::validation::BytesValidator::validate_length(&description, 1, 1000).unwrap();
crate::validation::BytesValidator::validate_length(&content_hash, 32, 32).unwrap();
// Since they are Bytes, we check length. Propagate as a proper
// contract error instead of panicking the invocation (#485).
crate::validation::BytesValidator::validate_length(&title, 1, 100)
.map_err(|_| TokenizationError::InvalidMetadata)?;
crate::validation::BytesValidator::validate_length(&description, 1, 1000)
.map_err(|_| TokenizationError::InvalidMetadata)?;
crate::validation::BytesValidator::validate_length(&content_hash, 32, 32)
.map_err(|_| TokenizationError::InvalidMetadata)?;

if royalty_percentage > 100 {
panic!("Royalty percentage cannot exceed 100");
Expand Down
Loading