rubocop: Fix the patch for Parser::Source::Comment#1035
Open
tk0miya wants to merge 1 commit into
Open
Conversation
RuboCop::Ext::Comment should be included into Parser::Source::Comment, not RuboCop::AST::Comment. The current patch is incorrect. This fixes the patch to be applied to the correct class. ref: * ruby#1020 * https://github.com/rubocop/rubocop/blob/master/lib/rubocop/ext/comment.rb
|
@tk0miya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
kozy4324
reviewed
Jun 17, 2026
| end | ||
|
|
||
| module Parser | ||
| class Source |
Contributor
There was a problem hiding this comment.
Suggested change
| class Source | |
| module Source |
The test output shows:
Duplicated declaration: ::Parser::Source (RBS::DuplicatedDeclarationError)
::Parser::Source is already defined as a module:
Changing this should resolve the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuboCop::Ext::Comment should be included into Parser::Source::Comment, not RuboCop::AST::Comment. The current patch is incorrect. This fixes the patch to be applied to the correct class.
ref: