Skip to content

rubocop: Fix the patch for Parser::Source::Comment #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tk0miya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rubocop: Fix the patch for Parser::Source::Comment #1035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions gems/rubocop/1.57/rubocop.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,16 +193,20 @@ module RuboCop
end
end

# Patch to RuboCop::AST::*
# Patch to RuboCop::AST::* and Parser::Source::Comment

module RuboCop
module AST
class Comment
include Ext::Comment
end

class ProcessedSource
include Ext::ProcessedSource
end
end
end

module Parser
class Source

@kozy4324 kozy4324 Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Source
module Source

The test output shows:

Duplicated declaration: ::Parser::Source (RBS::DuplicatedDeclarationError)

::Parser::Source is already defined as a module:

gem_rbs_collection/gems/parser/3.2/parser.rbs

Line 53 in 3099a93

module Source

Changing this should resolve the issue.

class Comment
include RuboCop::Ext::Comment
end
end
end
Loading