Fix voting-portal list header titles to use translated category header names#2669
Draft
Copilot wants to merge 2 commits into
Draft
Fix voting-portal list header titles to use translated category header names#2669Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…itles Agent-Logs-Url: https://github.com/sequentech/step/sessions/b104cbf4-14b0-468b-8b34-d228e9eec9b5 Co-authored-by: xalsina-sequent <173030604+xalsina-sequent@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix voting portal list headers to use candidate translations
Fix voting-portal list header titles to use translated category header names
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voting Portal list headers were rendered from the raw
candidate_typekey, even when translated list names were available. This change makes list header rendering use localized category/header data first, with safe fallbacks.List title source precedence
category.headertranslation (name/name_i18n) when present.contest.presentation.types_presentation[title]translation.titlekey.Remove forced overwrite of translated type presentation
types_presentationnames with the raw type key.Keep accessibility label aligned with rendered title
collapseToggleAriaLabelnow uses the same resolvedlistTitleshown in the UI.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git(dns block)clients2.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git(dns block)clientservices.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git(dns block)safebrowsingohttpgateway.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git(dns block)www.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git(dns block)If you need me to access, download, or install something from one of these locations, you can either: