Skip to content

Fix voting-portal list header titles to use translated category header names#2669

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-voting-portal-header-translation
Draft

Fix voting-portal list header titles to use translated category header names#2669
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-voting-portal-header-translation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026

Voting Portal list headers were rendered from the raw candidate_type key, even when translated list names were available. This change makes list header rendering use localized category/header data first, with safe fallbacks.

  • List title source precedence

    • Prefer category.header translation (name/name_i18n) when present.
    • Fallback to contest.presentation.types_presentation[title] translation.
    • Final fallback to raw title key.
  • Remove forced overwrite of translated type presentation

    • Dropped the unconditional assignment that replaced types_presentation names with the raw type key.
  • Keep accessibility label aligned with rendered title

    • collapseToggleAriaLabel now uses the same resolved listTitle shown in the UI.
const listTitle =
  translate(category.header, "name", i18n.language) ??
  translate(listPresentation, "name", i18n.language) ??
  title

<CandidatesList title={listTitle} ... />

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git (dns block)
  • clientservices.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=6310 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/com.google.Chrome.scoped_dir.uvWpUQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,10368720688423879299,4055283715732398078,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10061230427443087097,9380462070705782109,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --headless --disable-gpu --no-sandbox --screenshot=/home/REDACTED/work/step/step/packages/voting-portal-list-header-fix.png --window-size=1440,900 http://localhost:3000/ de/node/bin/git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

…itles

Agent-Logs-Url: https://github.com/sequentech/step/sessions/b104cbf4-14b0-468b-8b34-d228e9eec9b5

Co-authored-by: xalsina-sequent <173030604+xalsina-sequent@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix voting portal list headers to use candidate translations Fix voting-portal list header titles to use translated category header names May 12, 2026
Copilot AI requested a review from xalsina-sequent May 12, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants