Skip to content

Fix voting-portal list header titles to use translated category header names #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix voting-portal list header titles to use translated category header names #2669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130965d
Initial plan
Copilot May 12, 2026
3a56676
fix(voting-portal): prefer translated category header name for list t…
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/voting-portal/src/components/AnswersList/AnswersList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ export const AnswersList: React.FC<AnswersListProps> = ({
contest.presentation?.collapsible_lists ?? ECollapsibleLists.DISABLED
const isCollapsible = collapsibleListsPolicy !== ECollapsibleLists.DISABLED
const defaultExpanded = collapsibleListsPolicy !== ECollapsibleLists.ENABLED_COLLAPSED
const collapseToggleAriaLabel = t("candidatesList.collapseToggle", {listTitle: title})
const showCandidatesLabel = t("candidatesList.showCandidates")
const hideCandidatesLabel = t("candidatesList.hideCandidates")
const categoryCandidateIds = new Set(category.candidates.map((candidate) => candidate.id))
Expand Down Expand Up @@ -159,7 +158,11 @@ export const AnswersList: React.FC<AnswersListProps> = ({
let listPresentation = contest.presentation?.types_presentation?.[title] ?? {
name: title,
}
listPresentation.name = title
const listTitle =
translate(category.header, "name", i18n.language) ??
translate(listPresentation, "name", i18n.language) ??
title
const collapseToggleAriaLabel = t("candidatesList.collapseToggle", {listTitle})
let subtypesPresentation = Object.entries(listPresentation.subtypes_presentation ?? {}).map(
([key, value]) => {
value.name = key
Expand All @@ -174,7 +177,7 @@ export const AnswersList: React.FC<AnswersListProps> = ({

return (
<CandidatesList
title={translate(listPresentation, "name", i18n.language) ?? title}
title={listTitle}
isActive={!isReview && isActive}
isCheckable={checkableLists}
checked={isChecked()}
Expand Down