Skip to content

Frame with instance location information on AlterSchema #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jviotti wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Frame with instance location information on AlterSchema #2103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/jsonschema/transformer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ auto SchemaTransformer::check(
const std::optional<JSON::String> &default_dialect,
const std::optional<JSON::String> &default_id) const
-> std::pair<bool, std::uint8_t> {
SchemaFrame frame{SchemaFrame::Mode::Locations};
SchemaFrame frame{SchemaFrame::Mode::Instances};

// If we use the default id when there is already one, framing will duplicate
// the locations leading to duplicate check reports
Expand Down Expand Up @@ -163,7 +163,7 @@ auto SchemaTransformer::apply(

bool result{true};
while (true) {
SchemaFrame frame{SchemaFrame::Mode::References};
SchemaFrame frame{SchemaFrame::Mode::Instances};
frame.analyse(schema, walker, resolver, default_dialect, default_id);
std::unordered_set<Pointer> visited;

Expand Down