Support for slim-api, ctsm model & fixes#137
Merged
Merged
Conversation
spl-arif
requested review from
kbhos-splunk,
kupratyu-splunk and
vvarshney-splunk
and removed request for
kbhos-splunk and
kupratyu-splunk
July 22, 2026 10:18
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24cd764edb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ternal mode Splunk's oauth2_settings.issuer_uri (the JWT "iss" claim on every interactive token) was hardcoded to a literal string decoupled from splunkConfiguration.endpoint, which feeds SPLUNK_ISSUERS on saia/slim via buildSplunkIssuersVal. The two also differed in scheme (http vs https) and service name (missing the Splunk Operator's own "splunk-" prefix), so CMP auth rejected every real token with "Issuer not allowed"/"Malformed JWT" and AI Tier's refresh_models silently returned no models. Both values now derive from AI_STANDALONE_NAME/AI_NS and match byte-for-byte in the https://splunk-<name>-standalone-service.<ns>.svc.<domain>:8089 form already used by the operator's SplunkCustomResourceRef path. Verified live: minted a real interactive JWT and confirmed slim-api's chat/models endpoint now returns models end-to-end. Co-Authored-By: Claude <noreply@anthropic.com>
- Split the metrics port into a dedicated internal-only ClusterIP Service
(reconcileSlimMetricsService) so NodePort/LoadBalancer public exposure
never publishes /metrics or allocates an extra NodePort for it. The new
Service carries the "component" label so the existing ServiceMonitor
selector (app+component) actually matches it.
- Fix reconcileSlimService to set Type/Ports/Selector inside the
CreateOrUpdate mutate callback instead of before it, since CreateOrUpdate
reloads the live Service first and was discarding the templated NodePort
on both create and update.
- Honor AIPlatformScheme when synthesizing AIPlatformUrl instead of
hardcoding http://, so HTTPS-only Ray endpoints work.
- Populate slim.yaml's instanceScale for all GPU tiers so slim-only
AIPlatforms (saia disabled) actually get GPU worker replicas to schedule
the FmTimeseries model on.
- Guard the SAIA application blocks in applications.yaml with
{{- if .Replicas.X }} so slim-only platforms don't render SAIA templates
referencing replica counts that were never set (avoiding <no value>
Go-template output in the rendered Ray Serve config).
Co-Authored-By: Claude <noreply@anthropic.com>
artifacts.yaml's CRD schema still only allowed "saia" or "seca" for features[].name, so applying an AIPlatform/AIService CR with the slim feature enabled was rejected by API server validation. Add "slim" to both enums. Co-Authored-By: Claude <noreply@anthropic.com>
spl-arif
requested review from
kbhos-splunk
and removed request for
vvarshney-splunk
July 23, 2026 10:40
kbhos-splunk
approved these changes
Jul 23, 2026
spl-arif
added a commit
that referenced
this pull request
Jul 23, 2026
- Split the metrics port into a dedicated internal-only ClusterIP Service
(reconcileSlimMetricsService) so NodePort/LoadBalancer public exposure
never publishes /metrics or allocates an extra NodePort for it. The new
Service carries the "component" label so the existing ServiceMonitor
selector (app+component) actually matches it.
- Fix reconcileSlimService to set Type/Ports/Selector inside the
CreateOrUpdate mutate callback instead of before it, since CreateOrUpdate
reloads the live Service first and was discarding the templated NodePort
on both create and update.
- Honor AIPlatformScheme when synthesizing AIPlatformUrl instead of
hardcoding http://, so HTTPS-only Ray endpoints work.
- Populate slim.yaml's instanceScale for all GPU tiers so slim-only
AIPlatforms (saia disabled) actually get GPU worker replicas to schedule
the FmTimeseries model on.
- Guard the SAIA application blocks in applications.yaml with
{{- if .Replicas.X }} so slim-only platforms don't render SAIA templates
referencing replica counts that were never set (avoiding <no value>
Go-template output in the rendered Ray Serve config).
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Changes Made
Testing Performed
make test)make lint)Test Environment
Test Steps
Documentation
Checklist
Breaking Changes
Impact:
Migration Path:
Screenshots/Recordings
Additional Notes
Reviewer Notes
Please pay special attention to:
Commit Message Convention: This PR follows Conventional Commits