-
Notifications
You must be signed in to change notification settings - Fork 6
Support for slim-api, ctsm model & fixes #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd70926
feat: support slim-api service
spl-arif 02eb07d
feat: deploy CTSM model
spl-arif 24cd764
feat: splunk issues for slim-api & deployment support
spl-arif cc70465
fix(k0s): align Splunk issuer_uri with SPLUNK_ISSUERS endpoint for in…
spl-arif c4957c8
fix(slim): address PR #137 P2 review findings
spl-arif 90ecaed
fix(crds): add slim to the AIPlatform/AIService feature name enum
spl-arif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| applicationScale: | ||
| FmTimeseries: 1 | ||
| instanceScale: | ||
| L40S: | ||
| l40s-1-gpu: 1 | ||
| H100: | ||
| h100-1-gpu: 1 | ||
| H100_NVL: | ||
| h100-nvl-1-gpu: 1 | ||
| RTX_PRO_6000_BLACKWELL: | ||
| rtx-pro-6000-blackwell-1-gpu: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package slim | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| aiv1 "github.com/splunk/splunk-ai-operator/api/v1" | ||
| "github.com/splunk/splunk-ai-operator/pkg/ai/features/common" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/client-go/tools/record" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| type SlimFactory struct{} | ||
|
|
||
| func (f *SlimFactory) New(ctx context.Context, c client.Client, scheme *runtime.Scheme, ai *aiv1.AIService, recorder record.EventRecorder) (common.FeatureHandler, error) { | ||
| return &SlimReconciler{ | ||
| Client: c, | ||
| Scheme: scheme, | ||
| Recorder: recorder, | ||
| }, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package slim | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| aiv1 "github.com/splunk/splunk-ai-operator/api/v1" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/client-go/kubernetes/scheme" | ||
| "k8s.io/client-go/tools/record" | ||
| "sigs.k8s.io/controller-runtime/pkg/client/fake" | ||
| ) | ||
|
|
||
| func TestSlimFactory_New(t *testing.T) { | ||
| s := runtime.NewScheme() | ||
| _ = scheme.AddToScheme(s) | ||
| _ = aiv1.AddToScheme(s) | ||
|
|
||
| factory := &SlimFactory{} | ||
| fakeClient := fake.NewClientBuilder().WithScheme(s).Build() | ||
| recorder := record.NewFakeRecorder(10) | ||
|
|
||
| aiService := &aiv1.AIService{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "test-service", | ||
| Namespace: "default", | ||
| }, | ||
| } | ||
|
|
||
| handler, err := factory.New(context.Background(), fakeClient, s, aiService, recorder) | ||
|
|
||
| require.NoError(t, err) | ||
| require.NotNil(t, handler) | ||
|
|
||
| // Verify it returns a SlimReconciler | ||
| reconciler, ok := handler.(*SlimReconciler) | ||
| assert.True(t, ok, "Expected handler to be *SlimReconciler") | ||
| assert.NotNil(t, reconciler.Client) | ||
| assert.NotNil(t, reconciler.Scheme) | ||
| assert.NotNil(t, reconciler.Recorder) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.