Skip to content

apollo_propeller: add inbound_channel_capacity config field#13346

Merged
sirandreww-starkware merged 1 commit into
mainfrom
03-19-apollo_propeller_add_inbound_channel_capacity_config_field
Jun 11, 2026
Merged

apollo_propeller: add inbound_channel_capacity config field#13346
sirandreww-starkware merged 1 commit into
mainfrom
03-19-apollo_propeller_add_inbound_channel_capacity_config_field

Conversation

@sirandreww-starkware

@sirandreww-starkware sirandreww-starkware commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Config-only change (new field + default) with no behavioral impact until consumers start using the new parameter.

Overview
Adds a new Config::inbound_channel_capacity setting to parameterize the bounded handler→engine inbound channel size, with documentation describing its back-pressure behavior and a default of 256.

Written by Cursor Bugbot for commit d992b45. This will update automatically on new commits. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@guy-starkware guy-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch from 168163d to c7ce5e5 Compare March 26, 2026 19:15
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_backpressure_flood_test branch 2 times, most recently from 0d9a9b4 to faeab50 Compare March 29, 2026 10:51
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch from c7ce5e5 to 57e977b Compare March 29, 2026 10:51
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_backpressure_flood_test branch from faeab50 to 638b968 Compare March 29, 2026 14:54
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch 2 times, most recently from 5f1a101 to d992b45 Compare March 30, 2026 11:08
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch from d992b45 to 02cdf4a Compare April 30, 2026 07:00
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_backpressure_flood_test branch from 159516a to 3b4fb1d Compare April 30, 2026 07:00
@cursor

cursor Bot commented Apr 30, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Config-only addition with a conservative default; no behavior change until callers wire the field into channel creation.

Overview
Adds inbound_channel_capacity to propeller Config, documenting it as the bounded channel size between each handler and the engine for inbound units.

When the channel is full, handlers stop reading from the network so yamux flow control can slow the remote peer. Default sets the value to 16.

Reviewed by Cursor Bugbot for commit ef9da12. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch from 02cdf4a to c708962 Compare April 30, 2026 09:42
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_backpressure_flood_test branch from 3b4fb1d to a6b2d65 Compare April 30, 2026 09:42
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch from c708962 to ae3023d Compare April 30, 2026 09:47
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_backpressure_flood_test branch from a6b2d65 to 0aa1086 Compare April 30, 2026 09:47
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 31, 2026
@github-actions github-actions Bot closed this Jun 8, 2026
@sirandreww-starkware sirandreww-starkware changed the base branch from 03-19-apollo_propeller_add_backpressure_flood_test to graphite-base/13346 June 9, 2026 13:46
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch from ae3023d to 9183488 Compare June 9, 2026 13:47
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13346 to main June 9, 2026 13:47
@github-actions github-actions Bot removed the stale label Jun 10, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 03-19-apollo_propeller_add_inbound_channel_capacity_config_field branch from 9183488 to ef9da12 Compare June 10, 2026 13:51

@ShahakShama ShahakShama left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit 4aaf235 Jun 11, 2026
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants