apollo_propeller: add inbound_channel_capacity config field#13346
Conversation
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ShahakShama).
168163d to
c7ce5e5
Compare
0d9a9b4 to
faeab50
Compare
c7ce5e5 to
57e977b
Compare
faeab50 to
638b968
Compare
5f1a101 to
d992b45
Compare
d992b45 to
02cdf4a
Compare
159516a to
3b4fb1d
Compare
PR SummaryLow Risk Overview When the channel is full, handlers stop reading from the network so yamux flow control can slow the remote peer. Reviewed by Cursor Bugbot for commit ef9da12. Bugbot is set up for automated code reviews on this repo. Configure here. |
02cdf4a to
c708962
Compare
3b4fb1d to
a6b2d65
Compare
c708962 to
ae3023d
Compare
a6b2d65 to
0aa1086
Compare
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
0aa1086 to
eae40db
Compare
ae3023d to
9183488
Compare
9183488 to
ef9da12
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Note
Low Risk
Config-only change (new field + default) with no behavioral impact until consumers start using the new parameter.
Overview
Adds a new
Config::inbound_channel_capacitysetting to parameterize the bounded handler→engine inbound channel size, with documentation describing its back-pressure behavior and a default of256.Written by Cursor Bugbot for commit d992b45. This will update automatically on new commits. Configure here.