You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low Risk
Small, localized change to inbound polling order in network handler code; reduces DoS risk without touching auth or persistence.
Overview Fixes inbound back-pressure in the Propeller connection handler so behavior matches the documented “one batch at a time” model for unsent_units.
poll_inner now polls inbound substreams only whenunsent_units is empty, after draining to the bounded engine channel. Previously, inbound reads could continue while decoded units were still queued, so a fast peer could keep filling unsent_units even when the engine channel was back-pressured—risking unbounded memory growth.
Outbound sends are unchanged; the guard only limits when new wire batches are read and decoded.
Reviewed by Cursor Bugbot for commit 82de509. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.