Skip to content

Fix: call the license page the Unified License Manager - #204

Closed
jonwaldstein wants to merge 2 commits into
mainfrom
fix/unified-license-manager-name
Closed

jonwaldstein wants to merge 2 commits into
mainfrom
fix/unified-license-manager-name

Conversation

@jonwaldstein

@jonwaldstein jonwaldstein commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

We tell every plugin to call the license page the "Unified License Manager", and now Harbor follows its own rule.

  • The page title, the legacy license notice and every error message on the page use the new name.
  • The menu items ("Liquid Web Products" under Settings, "Licensing" in plugin menus) and the page URL stay the same.

Testing Instructions

  1. Go to Settings → Liquid Web Products. The browser tab title reads "Unified License Manager".
  2. Open a plugin's legacy license page that shows the Liquid Web notice. The link at the end reads "Unified License Manager" and opens the license page.
  3. Block the REST requests in dev tools and reload the license page. The error message starts with "Unified License Manager failed to…".
  4. bun run test:js and slic run wpunit cover the renamed strings.

Pre-review Checklist

  • Acceptance criteria satisfied and tested
  • Changelog entry added
  • E2E or unit tests updated

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Renamed the admin page to Unified License Manager across page titles, notices, error messages, and related user-facing labels.
    • Updated the logo’s alternative text to Liquid Web.

jonwaldstein and others added 2 commits October 8, 2026 09:30
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 647de9cf-c64f-4321-a1b9-1adef2a17b1e
📥 Commits

Reviewing files that changed from the base of the PR and between b18d380 and 8ed34e0.

⛔ Files ignored due to path filters (1)
  • build-dev/index.js.map is excluded by !**/*.map
📒 Files selected for processing (24)
  • .github/scripts/playground-preview-comment.js
  • .github/workflows/tests-e2e.yml
  • build-dev/index.asset.php
  • build-dev/index.js
  • build/index.asset.php
  • build/index.js
  • changelog/fix-unified-license-manager-name.yaml
  • docs/architecture/fat-leader-thin-instance.md
  • docs/guides/integration.md
  • docs/guides/testing.md
  • docs/harbor.md
  • docs/subsystems/frontend.md
  • resources/js/components/molecules/FilterBar.tsx
  • resources/js/context/harbor-data-context.tsx
  • resources/js/hooks/use-resolvable-select/use-resolvable-select-with-error.ts
  • resources/js/store/actions.ts
  • resources/js/store/resolvers.ts
  • skill/SKILL.md
  • src/Harbor/API/Functions/Actions/Display_Legacy_License_Page_Notice.php
  • src/Harbor/API/Functions/Actions/Register_Submenu.php
  • src/Harbor/Admin/Feature_Manager_Page.php
  • tests/e2e/software-manager.spec.ts
  • tests/js/hooks/useWelcomeLicenseForm.test.ts
  • tests/wpunit/API/Functions/Actions/Display_Legacy_License_Page_NoticeTest.php

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The page title and related user-facing copy now use “Unified License Manager.” Documentation, workflow labels, tests, and built asset versions also reflect the updates. Error codes, API calls, and execution flow remain unchanged.

Changes

Unified License Manager naming

Layer / File(s) Summary
Admin title and legacy notices
src/Harbor/Admin/Feature_Manager_Page.php, src/Harbor/API/Functions/Actions/Register_Submenu.php, src/Harbor/API/Functions/Actions/Display_Legacy_License_Page_Notice.php, tests/wpunit/API/Functions/Actions/Display_Legacy_License_Page_NoticeTest.php, changelog/fix-unified-license-manager-name.yaml
Admin page titles and legacy license notice links now use “Unified License Manager.” The notice tests and patch changelog entry reflect the updated name.
Frontend labels and errors
resources/js/components/molecules/FilterBar.tsx, resources/js/context/harbor-data-context.tsx, resources/js/hooks/use-resolvable-select/use-resolvable-select-with-error.ts, resources/js/store/*, build-dev/index.js, build/index.asset.php, build-dev/index.asset.php, tests/js/hooks/useWelcomeLicenseForm.test.ts
The logo alt text and resolver, feature, and license error messages use the updated name. The test fixture and built asset versions are updated.
Documentation and test references
docs/architecture/fat-leader-thin-instance.md, docs/guides/integration.md, docs/guides/testing.md, docs/harbor.md, docs/subsystems/frontend.md, skill/SKILL.md, .github/scripts/playground-preview-comment.js, .github/workflows/tests-e2e.yml, tests/e2e/software-manager.spec.ts
Documentation and naming guidance use “Unified License Manager.” Playground descriptions, the E2E workflow label, and the E2E suite name also use the updated page name.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: d4mation

Merge Risk: ⚪ Minimal · up to 8ed34

The page, notices, and error messages now use the Unified License Manager name, while the menu and URL remain unchanged. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ❓ Inconclusive Docstring coverage is 45.45% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 14 files. (9 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: renaming the license page to Unified License Manager.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 45.45% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 14 files. (9 skipped: 8 unsupported, 1 too large.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ast-grep (0.45.3)
build-dev/index.js

ast-grep timed out on this file


Comment @coderabbitai help to get the list of available commands.

@jonwaldstein
jonwaldstein marked this pull request as draft October 8, 2026 18:53
@jonwaldstein

Copy link
Copy Markdown
Contributor Author

Closing in favor of #206. The page is now called "Nexcess Licensing" instead of "Unified License Manager".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant