Skip to content

Fix: rebrand the license page to Nexcess Licensing - #206

Open
jonwaldstein wants to merge 8 commits into
mainfrom
fix/nexcess-licensing-name
Open

jonwaldstein wants to merge 8 commits into
mainfrom
fix/nexcess-licensing-name

Conversation

@jonwaldstein

@jonwaldstein jonwaldstein commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Harbor's license page is now called "Nexcess Licensing", and the "Liquid Web" copy around it now says Nexcess. This replaces #204, which used "Unified License Manager".

  • The page title, the welcome screen heading, the legacy license notice and every error message on the page say "Nexcess Licensing".
  • The Settings menu item is now Nexcess Licensing (was "Liquid Web Products"), and the license link reads "Manage license in Nexcess".
  • The page header shows the Nexcess logo instead of the Liquid Web one.
  • The legacy license notice says the plugin is "now part of Nexcess's software offerings".
  • The welcome screen drops the "Liquid Web by Nexcess" line, since the heading already says Nexcess.
  • The integration guide, skill/SKILL.md and the AGENTS.md snippet in the README now tell plugins to say "Nexcess Licensing". The old "brand-neutral" reasoning is gone.
  • The page URL and the "Licensing" item in plugin menus stay as they are.

Testing Instructions

  1. Look under Settings. The menu item reads "Nexcess Licensing".
  2. Open it with no license saved. The welcome screen heading reads "Nexcess Licensing" with no "Liquid Web by Nexcess" line under it. The browser tab title also reads "Nexcess Licensing".
  3. Save a license. The page header shows the Nexcess logo, and the link under the license card reads "Manage license in Nexcess".
  4. Open a plugin's legacy license page that shows the notice. It says "now part of Nexcess's software offerings", and the link at the end reads "Nexcess Licensing".
  5. Block the REST requests in dev tools and reload the license page. The error message starts with "Nexcess Licensing failed to…".
  6. bun run test:js and slic run wpunit cover the renamed strings.

Pre-review Checklist

  • Acceptance criteria satisfied and tested
  • Changelog entry added
  • E2E or unit tests updated

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Renamed the licensing page and Settings menu item to “Nexcess Licensing.”
    • Updated the welcome screen, logo, license-management links, notices, and error messages to use Nexcess branding.
    • Updated related documentation and test labels to reflect the new name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 5e68b6f0-9f2c-4b58-b689-034c5ac0c79d
📥 Commits

Reviewing files that changed from the base of the PR and between b18d380 and d38a9ef.

⛔ Files ignored due to path filters (3)
  • build-dev/index.js.map is excluded by !**/*.map
  • resources/img/logo-lw.svg is excluded by !**/*.svg
  • resources/img/logo-nexcess-lockup.svg is excluded by !**/*.svg
📒 Files selected for processing (40)
  • .github/scripts/playground-preview-comment.js
  • .github/workflows/tests-e2e.yml
  • README.md
  • build-dev/index.asset.php
  • build-dev/index.js
  • build/index.asset.php
  • build/index.js
  • changelog/fix-nexcess-licensing-name.yaml
  • docs/architecture/conventions.md
  • docs/architecture/fat-leader-thin-instance.md
  • docs/architecture/unified-license-key-system-design.md
  • docs/glossary.md
  • docs/guides/integration.md
  • docs/guides/testing.md
  • docs/harbor.md
  • docs/subsystems/frontend.md
  • docs/subsystems/licensing.md
  • resources/js/components/atoms/NexcessLogo.tsx
  • resources/js/components/molecules/FeatureRow.tsx
  • resources/js/components/molecules/FilterBar.tsx
  • resources/js/components/molecules/NotActivatedBanner.tsx
  • resources/js/components/organisms/LicenseSection.tsx
  • resources/js/components/templates/WelcomeShell.tsx
  • resources/js/context/harbor-data-context.tsx
  • resources/js/hooks/use-resolvable-select/use-resolvable-select-with-error.ts
  • resources/js/lib/activation-url.ts
  • resources/js/store/actions.ts
  • resources/js/store/resolvers.ts
  • skill/SKILL.md
  • src/Harbor/API/Functions/Actions/Display_Legacy_License_Page_Notice.php
  • src/Harbor/API/Functions/Actions/Register_Submenu.php
  • src/Harbor/Admin/Feature_Manager_Page.php
  • src/Harbor/global-functions.php
  • tests/e2e/smoke.spec.ts
  • tests/e2e/software-manager.spec.ts
  • tests/e2e/welcome-screen.spec.ts
  • tests/js/components/AppLoader.test.tsx
  • tests/js/components/WelcomeShell.test.tsx
  • tests/js/hooks/useWelcomeLicenseForm.test.ts
  • tests/wpunit/API/Functions/Actions/Display_Legacy_License_Page_NoticeTest.php

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The licensing page and related interface text, notices, error messages, tests, documentation, and project references now use Nexcess branding. The logo and welcome heading are updated. Licensing behavior and request handling are unchanged.

Changes

Nexcess Licensing rebrand

Layer / File(s) Summary
Admin interface and runtime messages
src/Harbor/..., resources/js/..., build*/..., tests/...
Admin page labels, frontend branding, logo, and license-management text now use Nexcess names. Legacy-license notices and runtime errors use the updated name. Tests assert the new labels and messages.
Documentation and project references
docs/..., README.md, skill/SKILL.md, .github/..., changelog/...
Architecture, integration, testing, and agent guidance now refer to Nexcess Licensing and Nexcess products. The E2E job and Playground references use the updated page name.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to d38a9

This is a branding update to the license page and related text. Licensing behavior and request handling are unchanged, so merge risk is minimal.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ❓ Inconclusive Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 25 files. (14 skipped… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: rebranding the license page to Nexcess Licensing.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 25 files. (14 skipped: 13 unsupported, 1 too large.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ast-grep (0.45.3)
build-dev/index.js

ast-grep timed out on this file


Comment @coderabbitai help to get the list of available commands.

jonwaldstein and others added 2 commits October 8, 2026 20:58
@jonwaldstein jonwaldstein changed the title Fix: call the license page Nexcess Licensing Fix: rebrand the license page to Nexcess Licensing Oct 8, 2026
jonwaldstein and others added 3 commits October 8, 2026 21:01
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jonwaldstein jonwaldstein added the playground Build a WordPress Playground preview for this pull request label Oct 8, 2026
jonwaldstein and others added 2 commits October 8, 2026 21:06
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

WordPress Playground Preview

Try this pull request in a throwaway WordPress in your browser. Harbor Dev Tools runs this branch of Harbor as the leader, licensed with the lwsw-unified-pro-2026 fixture key. Free features can be enabled; premium ones cannot, because their downloads need a real key. Built 2026-10-08 21:10 UTC from d38a9ef, or download the zip for a site of your own.

Harbor Dev Tools only

Open WordPress Playground Preview

Each button below also installs the latest release of one plugin beside Harbor Dev Tools. That plugin bundles its own copy of Harbor, and Harbor Dev Tools stays the leader.

With GiveWP

Open WordPress Playground Preview with GiveWP

With The Events Calendar

Open WordPress Playground Preview with The Events Calendar

With Kadence Blocks

Open WordPress Playground Preview with Kadence Blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playground Build a WordPress Playground preview for this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant