fix(fs-node): close the original descriptor after stream release - #1286
Open
xianjianlf2 wants to merge 1 commit into
Open
fix(fs-node): close the original descriptor after stream release#1286xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
FileHandle.close()waits for an active Web Stream reference, cancelling that stream runsunref(). The method setsfd = -1before passing the descriptor tofs.close(), so the pending close rejects withEBADFand the original descriptor remains open. Capture the original descriptor before marking the handle closed, as the immediate close path already does.Regression tests cover cancellation both before and after a stream read, shared concurrent close calls, and an assertion that the original descriptor is actually closed. Both new cases fail with
EBADFbefore the fix.Validation: full
yarn test, workspace typechecks, and repository Prettier check passed.AI-assisted implementation and validation.