Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/fs-node/src/FileHandle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,10 @@ export class FileHandle extends EventEmitter implements IFileHandle {
private unref(): void {
this.refs--;
if (this.refs === 0) {
const currentFd = this.fd;
this.fd = -1;
if (this.closeResolve) {
promisify(this.fs, 'close')(this.fd).then(this.closeResolve, this.closeReject);
promisify(this.fs, 'close')(currentFd).then(this.closeResolve, this.closeReject);
}
}
}
Expand Down
17 changes: 17 additions & 0 deletions packages/fs-node/src/__tests__/volume/FileHandle.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,23 @@ describe('FileHandle', () => {
});

describe('reference counting', () => {
it.each([false, true])('closes the original descriptor after stream cancellation (read=%s)', async read => {
const fs = createFs({ '/test': 'content' });
const handle = await fs.promises.open('/test', 'r');
const fd = handle.fd;
const reader = handle.readableWebStream().getReader();
if (read) await reader.read();
const closed = handle.close();
const closedAgain = handle.close();
expect(closedAgain).toBe(closed);
expect(fs.fstatSync(fd).isFile()).toBe(true);
await reader.cancel();
await expect(closed).resolves.toBeUndefined();
expect(handle.fd).toBe(-1);
expect(() => fs.fstatSync(fd)).toThrow(expect.objectContaining({ code: 'EBADF' }));
await expect(handle.close()).resolves.toBeUndefined();
});

it('should handle multiple close calls gracefully', async () => {
const fs = createFs();
fs.writeFileSync('/test', 'content');
Expand Down
Loading