Reject classes that refuse serialization whatever methods they declare - #47
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serialize()andunserialize()refuse the classes PHP flags as not serializable, subclasses included, whatever methods they declare.deepclone_to_array()let such subclasses through when they declared__wakeup()or__unserialize(), while the polyfill let through the ones declaring__sleep()or__serialize():deepclone_from_array()didn't check these classes at all: a payload could create aClosureor aGeneratorthat crashed on first use. It now rejects them likeunserialize()does, anddeepclone_hydrate()rejects the user classes among them, like it does for internal ones.Anonymous classes are flagged too, but they keep round-tripping when they declare
__wakeup()or__unserialize(), throwables included: VarExporter's tests rely on it. The polyfill gets the same rules in symfony/polyfill#699.