Repository navigation
Wheels report their own version, not "<tag>-128-NOTFOUND" - #31
Merged
Merged
Conversation
The release archives pass -DVCELL_VERSION_STRING=<version>, but the wheel builds (cibuildwheel + scikit-build-core) pass nothing, so CMake fell back to git describe, which fails there (exit 128): version() reported e.g. "v0.11.0-128-NOTFOUND". When scikit-build-core is building and no version string is given, use the wheel's own version (SKBUILD_PROJECT_VERSION), as the archives do. test_version_names_the_installed_package fails on the released 0.11.0 wheel. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyvcell_fvsolver.version()from the PyPI wheels reports a broken version, e.g.Finite Volume version v0.11.0-128-NOTFOUND with smoldyn version 2.38; 0.10.8's saidv0.10.8-128-NOTFOUND. The release archives' executables are fine (Finite Volume version 0.10.8 …).Cause
-DVCELL_VERSION_STRING=<version>to CMake.CMakeLists.txtfalls back togit describe. Git fails in that build environment (exit 128), andGetGitRevisionDescriptionturns the failure into…-128-NOTFOUND.Fix
When scikit-build-core is building (
SKBUILD_PROJECT_VERSIONis defined) and no version string is given, use the wheel's own version frompyproject.toml.version()then saysFinite Volume version 0.11.x …, matching the archives and__version__. Native builds, and anything that passesVCELL_VERSION_STRING, are unchanged.Test
New
test_version_names_the_installed_packagechecks thatversion()contains noNOTFOUNDand names the installed package's version. It fails on the released 0.11.0 wheel from PyPI withFinite Volume version v0.11.0-128-NOTFOUND …. CI runs it on every platform's wheel, on Python 3.12 and 3.14.🤖 Generated with Claude Code