Fix up URL stripping#285
Open
yoavweiss wants to merge 1 commit into
Open
Conversation
aluhrs13
approved these changes
Sep 3, 2025
aluhrs13
left a comment
aluhrs13
left a comment
There was a problem hiding this comment.
LGTM, but the Github issue might have new feedback?
Contributor
Author
|
@evilpie - care to take a look at this algorithm changes and see if there's something else you'd like us to add? |
Member
|
I think the navigation redirect issue needs to be fixed when we generate the report for that specific action. I suppose you could pass it as a boolean to this algorithm, but it seems better to hide the information even earlier on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix up the algorithm based on w3c/webappsec-csp#734 (comment) from @annevk