Skip to content

Use "Strip URL" from the Reporting API#734

Open
yoavweiss wants to merge 1 commit into
mainfrom
use_strip_url_from_reporting
Open

Use "Strip URL" from the Reporting API#734
yoavweiss wants to merge 1 commit into
mainfrom
use_strip_url_from_reporting

Conversation

@yoavweiss

@yoavweiss yoavweiss commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

We recently added an exported strip URL for use in reporting to the Reporting API. This PR makes use of that, and drops the CSP-only algorithm


Preview | Diff

@yoavweiss yoavweiss requested review from antosart and mikewest June 13, 2025 07:12
@annevk

annevk commented Jun 13, 2025

Copy link
Copy Markdown
Member

While this is identical, the algorithm is wrong. This would have all URLs end with #. You need to set fragment to null (or use the "exclude fragment" serialization option).

@yoavweiss

Copy link
Copy Markdown
Contributor Author

While this is identical, the algorithm is wrong. This would have all URLs end with #. You need to set fragment to null (or use the "exclude fragment" serialization option).

Thanks! I'll fix up the reporting algo

@yoavweiss

Copy link
Copy Markdown
Contributor Author

@annevk Filed w3c/reporting#285 (can't add you as a reviewer for some reason..)

@evilpie

evilpie commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Please hold off on merging this. I am going to report some significant differences between the specifications and the implementations shortly.

@evilpie

evilpie commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

#735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants