Update: Bump the bundle to Symfony 8 / PHP 8.4 (Case 212955) - #27
Merged
Conversation
Widen all symfony/* constraints to ^8.0, raise the PHP floor to ^8.4 (Symfony 8 requires PHP >= 8.4.1), and raise the CI PHP version to 8.4. Bump doctrine/doctrine-bundle to ^3.0 — v2.x has no Symfony 8 support. Six additional code fixes were needed to stay green on Symfony 8: - WebfactoryNewsletterRegistrationExtension::load(): add missing `: void` return type (Symfony 8 made ExtensionInterface::load() strict). - Callback constraint: array-key constructor syntax (['callback' => ...]) was removed; pass the callable directly instead. - Choice constraint: array options constructor was removed; use named arguments (choices:, multiple:, min:). - Doctrine test config: auto_generate_proxy_classes removed from DoctrineBundle 3's ORM configuration tree. - AppClassTemplatesTest: call $config->enableNativeLazyObjects(true) — Symfony 8 dropped the LazyGhostTrait that Doctrine ORM's old file-based proxy system relied on; PHP 8.4 native lazy objects replace it. - All four Foundry factories: PersistentProxyObjectFactory → PersistentObjectFactory — the proxy mechanism is gone in Symfony 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen all symfony/* constraints to ^8.0, raise the PHP floor to ^8.4 (Symfony 8 requires PHP >= 8.4.1), and raise the CI PHP version to 8.4. Bump doctrine/doctrine-bundle to ^3.0 — v2.x has no Symfony 8 support.
Six additional code fixes were needed to stay green on Symfony 8:
: voidreturn type (Symfony 8 made ExtensionInterface::load() strict).