Skip to content

Update: Bump the bundle to Symfony 8 / PHP 8.4 (Case 212955) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janopae merged 1 commit into from
Jul 31, 2026
Merged

Update: Bump the bundle to Symfony 8 / PHP 8.4 (Case 212955) #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request:

env:
PHP_VERSION: 8.3
PHP_VERSION: 8.4

jobs:
composer-require-checker:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request:

env:
PHP_VERSION: 8.3
PHP_VERSION: 8.4
TEMP: ${{ github.workspace }}/tmp

jobs:
Expand Down
40 changes: 20 additions & 20 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,38 @@
"license": "MIT",

"require": {
"php": "^8.2",
"php": "^8.4",
"ext-mbstring": "*",
"doctrine/collections": "^2.0",
"doctrine/orm": "^3.0",
"psr/log": "^3.0",
"ramsey/uuid": "^4.0",
"symfony/config": "^7.0",
"symfony/console": "^7.0",
"symfony/config": "^8.0",
"symfony/console": "^8.0",
"symfony/contracts": "^3.0",
"symfony/dependency-injection": "^7.0",
"symfony/doctrine-bridge": "^7.0",
"symfony/form": "^7.0",
"symfony/http-foundation": "^7.0",
"symfony/http-kernel": "^7.0",
"symfony/mailer": "^7.0",
"symfony/mime": "^7.0",
"symfony/options-resolver": "^7.0",
"symfony/routing": "^7.0",
"symfony/translation": "^7.0",
"symfony/validator": "^7.0",
"symfony/dependency-injection": "^8.0",
"symfony/doctrine-bridge": "^8.0",
"symfony/form": "^8.0",
"symfony/http-foundation": "^8.0",
"symfony/http-kernel": "^8.0",
"symfony/mailer": "^8.0",
"symfony/mime": "^8.0",
"symfony/options-resolver": "^8.0",
"symfony/routing": "^8.0",
"symfony/translation": "^8.0",
"symfony/validator": "^8.0",
"twig/twig": "^3.0"
},

"require-dev": {
"doctrine/common": "^2.0 | ^3.0",
"doctrine/doctrine-bundle": "^2.4",
"doctrine/doctrine-bundle": "^3.0",
"phpunit/phpunit": "^11.0",
"symfony/browser-kit": "^7.0",
"symfony/css-selector": "^7.0",
"symfony/framework-bundle": "^7.0",
"symfony/twig-bundle": "^7.0",
"symfony/yaml": "^7.0",
"symfony/browser-kit": "^8.0",
"symfony/css-selector": "^8.0",
"symfony/framework-bundle": "^8.0",
"symfony/twig-bundle": "^8.0",
"symfony/yaml": "^8.0",
"zenstruck/foundry": "^2.8"
},

Expand Down
2 changes: 1 addition & 1 deletion src/DependencyInjection/WebfactoryNewsletterRegistrationExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class WebfactoryNewsletterRegistrationExtension extends Extension
{
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$loader = new YamlFileLoader($container, new FileLocator(__DIR__));
$loader->load('services.yml');
Expand Down
2 changes: 1 addition & 1 deletion src/EditRegistration/TypeHasNewslettersElementTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ protected function addNewslettersElementToForm(FormBuilderInterface $builder, bo

$constraints = [];
if (true === $recipientHasToChooseAtLeastOne) {
$constraints[] = new Choice(['min' => 1, 'choices' => $choices, 'multiple' => true]);
$constraints[] = new Choice(choices: $choices, multiple: true, min: 1);
}

$builder->add(
Expand Down
4 changes: 1 addition & 3 deletions src/StartRegistration/EmailAddressType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,7 @@ public function configureOptions(OptionsResolver $resolver): void
'constraints' => [
new NotBlank(),
new Email(),
new Callback([
'callback' => $this->createEmailAddressIsAllowedToReceiveOptInEmailsConstraint(),
]),
new Callback($this->createEmailAddressIsAllowedToReceiveOptInEmailsConstraint()),
],
]);
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Factory/BlockedEmailAddressHashFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

use DateTimeImmutable;
use Webfactory\NewsletterRegistrationBundle\Entity\BlockedEmailAddressHash;
use Zenstruck\Foundry\Persistence\PersistentProxyObjectFactory;
use Zenstruck\Foundry\Persistence\PersistentObjectFactory;

final class BlockedEmailAddressHashFactory extends PersistentProxyObjectFactory
final class BlockedEmailAddressHashFactory extends PersistentObjectFactory
{
protected function defaults(): array
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Factory/NewsletterFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
namespace Webfactory\NewsletterRegistrationBundle\Tests\Factory;

use Webfactory\NewsletterRegistrationBundle\Tests\Entity\Dummy\Newsletter;
use Zenstruck\Foundry\Persistence\PersistentProxyObjectFactory;
use Zenstruck\Foundry\Persistence\PersistentObjectFactory;

final class NewsletterFactory extends PersistentProxyObjectFactory
final class NewsletterFactory extends PersistentObjectFactory
{
protected function defaults(): array
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Factory/PendingOptInFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
use DateTimeImmutable;
use Webfactory\NewsletterRegistrationBundle\Entity\EmailAddress;
use Webfactory\NewsletterRegistrationBundle\Tests\Entity\Dummy\PendingOptIn;
use Zenstruck\Foundry\Persistence\PersistentProxyObjectFactory;
use Zenstruck\Foundry\Persistence\PersistentObjectFactory;

final class PendingOptInFactory extends PersistentProxyObjectFactory
final class PendingOptInFactory extends PersistentObjectFactory
{
protected function defaults(): array
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Factory/RecipientFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

use Webfactory\NewsletterRegistrationBundle\Entity\EmailAddress;
use Webfactory\NewsletterRegistrationBundle\Tests\Entity\Dummy\Recipient;
use Zenstruck\Foundry\Persistence\PersistentProxyObjectFactory;
use Zenstruck\Foundry\Persistence\PersistentObjectFactory;

final class RecipientFactory extends PersistentProxyObjectFactory
final class RecipientFactory extends PersistentObjectFactory
{
protected function defaults(): array
{
Expand Down
1 change: 0 additions & 1 deletion tests/Fixtures/config/doctrine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
'path' => '%kernel.cache_dir%/test.db',
],
'orm' => [
'auto_generate_proxy_classes' => true,
'resolve_target_entities' => [
NewsletterInterface::class => Newsletter::class,
],
Expand Down
1 change: 1 addition & 0 deletions tests/Resources/AppClassTemplatesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ protected function setUp(): void
[__DIR__.'/../../Resources/app-class-templates'],
isDevMode: true,
);
$config->enableNativeLazyObjects(true);

$this->em = new EntityManager($connection, $config, $eventManager);
}
Expand Down
Loading