Stop sending orphaned entity IDs through ancestor-chain traversal - #25419
Open
tnajdek wants to merge 1 commit into
Open
Conversation
This change prevents stale IDs from blocking traversal of live entities that reuse the same indices. Fixes bevyengine#25416
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
requested changes
Aug 19, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Yes please to that regression test :)
alice-i-cecile
added
C-Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
mark_dirty_treesskips live entities after entity-index reuse #25416Solution
Stop sending orphaned entity IDs through ancestor-chain traversal. Unfortunately, that makes the optimized path slightly slower, but still considerably faster than with
StaticTransformOptimizations::Disabled.Testing
Minimal reproduction code: https://gist.github.com/tnajdek/e945d7a6f52db525d46d913e12f89873. Happy to convert this into a regression test.
Disclosure
I've used LLM to research this problem and, partially, to generate the reproduction code.