Skip to content

Stop sending orphaned entity IDs through ancestor-chain traversal #25419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnajdek wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

Stop sending orphaned entity IDs through ancestor-chain traversal #25419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions crates/bevy_transform/src/systems.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ pub fn mark_dirty_trees(
ComputeTaskPool::get().scope(|scope| {
traversal_channels.chunk_size = 1024;
consumer_channels.chunk_size = 1024;
let (traversal_rx, mut traversal_tx) = traversal_channels.unbounded();
let (traversal_rx, traversal_tx) = traversal_channels.unbounded();
let (consumer_rx, mut consumer_tx) = consumer_channels.unbounded();
let shared_bitset: &[core::sync::atomic::AtomicU64] = &shared_bitset;
let local_bitset = &*local_bitset;
Expand Down Expand Up @@ -262,12 +262,11 @@ pub fn mark_dirty_trees(
// dropped at the end of this closure, closing the channel and allowing the other tasks
// to exit.
//
// Note that we send the entity directly to the consumer as well, we do this to start
// feeding it work as soon as possible. The traversal worker should skip sending these
// leaves to the consumer because it has already been sent here.
// Note that we send changed entities directly to the consumer as well; we do this to
// start feeding it work as soon as possible. The traversal worker should skip sending
// these leaves to the consumer because they have already been sent here.
let mut producer = move || {
for entity in orphaned.read() {
let _ = traversal_tx.send_blocking(entity);
let _ = consumer_tx.send_blocking(entity);
}
// Changed<> table scans are slow, so we parallelize them to improve performance.
Expand Down