Repository navigation
fix(desktop): satisfy pubkey-truncation guard in receipt + time machine UI - #4
Merged
Merged
Conversation
The desktop-check guard rejects hand-rolled `pubkey.slice()` display truncation (truncated hex prefixes are vanity-forgeable). Route the receipt verifier's issuer/agent and the time machine's unnamed-author fallback through the canonical `truncateNpub` instead. Unblocks the Desktop Core CI job, which stopped at lint before the Tauri build. Signed-off-by: Eli <elijamesau@gmail.com>
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #3's CI failed at Desktop Domain / Desktop Core → "Desktop lint and format" (
just desktop-check). The repo'scheck:pubkey-truncationguard rejects ad-hocpubkey.slice(0, N)display truncation because truncated hex prefixes are vanity-forgeable; identity display must go throughtruncateNpub/truncatePubkey/<PubKey>. Two of the new files hand-rolled it.Because that step failed, the Tauri clippy/check/tests steps were skipped — this PR is what lets CI actually build the desktop crate with the Trust Receipts + Time Machine code.
Change
VerifyReceiptDialog.tsx: issuer + agent →truncateNpubTimeMachineScreen.tsx: unnamed-author fallback →truncateNpubshortKeyhelpers.Verified locally
node scripts/check-pubkey-truncation.mjs— clean (was 2 violations)node scripts/check-px-text.mjs— cleanbiome check— cleantsc --noEmit— cleanTest plan