Repository navigation
feat(discover): rename, rearrange and delete folders [PER-2760] - #2453
yasincaliskan wants to merge 10 commits into
Conversation
Device e2e flows affectedEvery suite (22 suites, 255 scenarios, 47 p0): a change under a path every screen depends on.
Run them:
|
yasin-ce
left a comment
There was a problem hiding this comment.
Adds rename, rearrange and delete to the native Discover folder screen through a header menu. One new store action backs it, and the behaviour is well tested. Layering, i18n, theme tokens and tests all follow the repo rules. My comments are about reuse and one fragile key derivation, and none of them block.
The Rearrange sheet hasn't been opened on a device yet. Please run it once (drag, ×, Done, close icon, Android back) before merging.
|
Thanks. Your inline comments didn't come through on the PR, so I went by the summary. Fixed in the last two commits:
If I missed one of your comments, please repost it. The device run of Rearrange is still open: on the simulator I couldn't get a dApp into a folder through the 5 s toast. Yasin will run drag, ×, Done, the close icon and back before merge. |
yasin-ce
left a comment
There was a problem hiding this comment.
The follow-ups are in. The Rearrange sheet now uses the folder's own keys, so Done can't drop a dApp whose url no longer normalises to its key, and a test covers that case. The logo, sheet options and pressIcon are shared now. Nothing new blocks, and CI is green.
I'd still like one device run of Rearrange (drag, ×, Done, close icon, swipe down, Android back) before merging.
|
Device check of Rearrange on the iOS simulator: the sheet opens from the folder menu; × then the close icon changes nothing; × then Done takes the dApp out and keeps the (now empty) folder. Dragging is not checked: only one testnet dApp could be filed into a folder. Filling folders needed #2456, which fixes the empty Add to folder sheet. |
|
Device run of Rearrange on the iOS simulator, with two dApps in a folder:
The run found one bug, fixed in the last commit: after Done, the folder screen showed only one of the two rows. FlashList v2 anchors the viewport on the first visible row and re-applies it on every data change, so the moved row ended up above the viewport. |
Description
People who made folders in native Discover can now tidy them. The folder screen header gets a "…" menu:
setFolderItems. Cancel (the close icon) changes nothing. × only takes a dApp out of the folder; it stays a favorite. Hidden when the folder is empty.Sheets open one after another; dismissing any of them changes nothing and tracks nothing. A folder deleted meanwhile makes the action a no-op.
Related Issues
Checklist
setFolderItems(order, unstarred keys dropped, dedupe, empty folder kept), the Rearrange sheet hook, the menu flow (each action, each dismiss, folder gone), and folder-screen integration (rename, delete, rearrange Done and Cancel, double tap).Contract Changes
setFolderItems(id, keys); no shape or version change.discover_folder_rename,discover_folder_delete,discover_folder_rearrange(removed_count).discover.folders.menu,.rearrangeand.delete_confirmin all six bundles.Behavior Changes
Additional Notes
Calls I made:
Left for later (minor, from the review):