Repository navigation
feat(discover): add a favorite to a folder with one tap [PER-2760] - #2456
Open
yasincaliskan wants to merge 3 commits into
Open
yasincaliskan wants to merge 3 commits into
yasincaliskan wants to merge 3 commits into
Conversation
3 of 5 tasks
Device e2e flows affectedEvery suite (22 suites, 255 scenarios, 47 p0): a change under a path every screen depends on.
Run them:
|
yasin-ce
approved these changes
Nov 16, 2026
yasin-ce
left a comment
Collaborator
There was a problem hiding this comment.
Turns the Add to folder sheet into a one-tap picker with an 'Added to {folder}' confirmation, and fixes the sheet rendering empty by dropping the footer. The logic is small, lives in the hook, and is well covered (including the fast-second-tap guard). Strings are in all six bundles and CI is green. I have a few minor questions, none blocking.
yasincaliskan
force-pushed
the
yasincaliskan/per-2760-discover-add-to-folder-one-tap
branch
from
November 16, 2026 14:07
efba64c to
b4bfa50
Compare
Collaborator
Author
|
Thanks. Your inline questions didn't come through on the PR (only the summary did). Could you repost them? The branch was restacked on #2453's latest commit; there are no changes to this PR's own code. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #2453 (folder menu); retarget to
mainonce that merges.The Add to folder sheet (opened from the "Added to favorites" toast) was hard to read: a checkbox per folder that saved instantly plus a Done button that only closed. On main it also rendered empty, with no folder rows. This makes it one tap:
Empty sheet:
PWSheetLayoutwraps body and footer in aflex: 1root, which has no height in anauto(content-sized) sheet, so the list collapsed. With the footer gone the body measures its content again.Related Issues
Checklist
Contract Changes
discover.add_to_folder.added("Added to {{folder}}") in all six bundles;discover.add_to_folder.doneremoved from all six.AddToFolderSheetResultis now{ folderName }(was'done').FolderDappAddon a folder tap and no longer sendsFolderDappRemove.Behavior Changes
Additional Notes
Found while testing, not fixed here:
PWSheetLayoutwith a footer in anautosheet withautoCreateContainer: falsestill collapses its body for any other sheet that uses that combination.Left for later (minor, from the review):