Skip to content

feat(discover): add a favorite to a folder with one tap [PER-2760] - #2456

Open
yasincaliskan wants to merge 3 commits into
yasincaliskan/per-2760-discover-folder-menufrom
yasincaliskan/per-2760-discover-add-to-folder-one-tap
Open

yasincaliskan wants to merge 3 commits into
yasincaliskan/per-2760-discover-folder-menufrom
yasincaliskan/per-2760-discover-add-to-folder-one-tap

Conversation

@yasincaliskan

@yasincaliskan yasincaliskan commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Stacked on #2453 (folder menu); retarget to main once that merges.

The Add to folder sheet (opened from the "Added to favorites" toast) was hard to read: a checkbox per folder that saved instantly plus a Done button that only closed. On main it also rendered empty, with no folder rows. This makes it one tap:

  • The sheet lists "New folder", then every folder. Tapping a folder adds the dApp, closes the sheet and shows "Added to {folder}".
  • "New folder" creates the folder holding the dApp, closes the sheet and shows the same toast.
  • A folder that already holds the dApp shows a check and is disabled.
  • No checkboxes, no Done. The sheet never removes a dApp from a folder; that's the folder's Rearrange (×) from feat(discover): rename, rearrange and delete folders [PER-2760] #2453.
  • Fast taps on a second row while the sheet closes are ignored, so the dApp is filed once.

Empty sheet: PWSheetLayout wraps body and footer in a flex: 1 root, which has no height in an auto (content-sized) sheet, so the list collapsed. With the footer gone the body measures its content again.

Related Issues

  • Linear PER-2760

Checklist

  • Tested locally on the iOS simulator: rows render; a folder tap closes the sheet, shows "Added to DeFi" and the folder count goes 0 → 1. Over the in-app browser too: the toast opens the sheet, a folder tap closes it and "Added to DeFi" shows above the browser. While there, feat(discover): rename, rearrange and delete folders [PER-2760] #2453's Rearrange: the sheet opens; × then the close icon changes nothing; × then Done empties the folder.
  • Not verified on a device: scrolling a long folder list, the "New folder" path end to end, and dragging in Rearrange (only one testnet dApp could be filed).
  • Reviewed: a whole-branch review; its two Important findings are fixed with tests.
  • Tests: the sheet hook (one tap, held folder, missing folder, never removes, new folder, dismissed name sheet, fast second tap) and the toast after the sheet (folder name, notifier read after the sheet closed, nothing on dismiss).

Contract Changes

  • i18n: new discover.add_to_folder.added ("Added to {{folder}}") in all six bundles; discover.add_to_folder.done removed from all six.
  • AddToFolderSheetResult is now { folderName } (was 'done').
  • Analytics: the sheet sends FolderDappAdd on a folder tap and no longer sends FolderDappRemove.

Behavior Changes

  • Multichain builds: one tap files a favorite into a folder, with a confirmation toast.
  • Algorand-only builds: no change.

Additional Notes

Found while testing, not fixed here:

  • PWSheetLayout with a footer in an auto sheet with autoCreateContainer: false still collapses its body for any other sheet that uses that combination.

Left for later (minor, from the review):

  • The disabled "already in this folder" row has no screen-reader hint.
  • Copy could name the folder as a folder (e.g. tr "{{folder}} klasörüne eklendi", de "Zum Ordner {{folder}} hinzugefügt").

@yasincaliskan
yasincaliskan requested a review from a team as a code owner November 16, 2026 13:43
@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown

PER-2760

@github-actions

Copy link
Copy Markdown

Device e2e flows affected

Every suite (22 suites, 255 scenarios, 47 p0): a change under a path every screen depends on.

  • apps/mobile/src/i18n/locales/de.json
  • apps/mobile/src/i18n/locales/en.json
  • apps/mobile/src/i18n/locales/es.json
  • apps/mobile/src/i18n/locales/fr.json
  • apps/mobile/src/i18n/locales/pt-BR.json
  • apps/mobile/src/i18n/locales/tr.json

Run them:

  • BrowserStack: the E2E / BrowserStack workflow with include left empty
  • A device: e2e/tools/run.sh <android|ios>

@yasin-ce yasin-ce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns the Add to folder sheet into a one-tap picker with an 'Added to {folder}' confirmation, and fixes the sheet rendering empty by dropping the footer. The logic is small, lives in the hook, and is well covered (including the fast-second-tap guard). Strings are in all six bundles and CI is green. I have a few minor questions, none blocking.

@yasincaliskan
yasincaliskan force-pushed the yasincaliskan/per-2760-discover-add-to-folder-one-tap branch from efba64c to b4bfa50 Compare November 16, 2026 14:07
@yasincaliskan

Copy link
Copy Markdown
Collaborator Author

Thanks. Your inline questions didn't come through on the PR (only the summary did). Could you repost them? The branch was restacked on #2453's latest commit; there are no changes to this PR's own code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants