Skip to content

bindings: JS/TS node.js support - #462

Draft
nrc wants to merge 5 commits into
mainfrom
nrc/node
Draft

nrc wants to merge 5 commits into
mainfrom
nrc/node

Conversation

@nrc

@nrc nrc commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

WIP!

closes #448, part of #102

Changes outside of the new bindings:

  • changes the way Python bindings create key files. Previous behaviour if key state is supplied is to create a new key file with default keys, then use the supplied keys for the session (which seems wrong. The next session without keys would use the default ones in the new file). New behaviour is that if keys are supplied, don't create the key file (I wasn't sure if writing out the keys into a new file was desirable).
  • adds half-closed support to the smoltcp netstack and a slightly more efficient way to send bytes to a stream
  • removes some obsolete cargo-vet entries
  • change Device::shutdown to take a reference to self
  • avoid some panics on shutdown which showed up in the new tests

Remaining work: enable publishing to npm

AI decl: Claude did most of the work, but I was driving and part of the code-test-review cycle. I.e., not 'one-shot'ted or vibe coded. I've reviewed the new Rust code in detail, and done my best with the JS/TS, but I'm not familiar enough with those languages to put trust in my review. The changes to the smol TCP netstack I am pretty unsure about: the change seems fine, but I'm not sure it's a sensible change to make.

@nrc
nrc force-pushed the nrc/node branch 4 times, most recently from 975e3e1 to 46b3fd0 Compare November 3, 2026 02:46
nrc added 5 commits November 3, 2026 17:36
Add TcpStream::shutdown to close only the sending half of a connection. Drop blocked commands whose requester has gone away rather than completing them and discarding the result.

Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Links in the getting started section of README.md still refer to wrong paths

1 participant