Skip to content

apollo_deployments: test overrides list match#14480

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/applicative-jsonnetfrom
nimrod/jsonnet/overrides-test
Open

apollo_deployments: test overrides list match#14480
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/applicative-jsonnetfrom
nimrod/jsonnet/overrides-test

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 3c60f09 to 9e1729b Compare June 14, 2026 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 0514557 to 123caa7 Compare June 14, 2026 11:56
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 9e1729b to 5a15200 Compare June 14, 2026 14:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 123caa7 to 24daabc Compare June 14, 2026 14:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 24daabc to 69cf6dd Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 5a15200 to 9fe115f Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware self-assigned this Jun 16, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 16, 2026 12:09
@cursor

cursor Bot commented Jun 16, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only change in deployment definitions; no runtime or deployment behavior is modified.

Overview
Adds a bidirectional drift test so Rust deployment replacer keys stay aligned with applicative_config.libsonnet override usage.

A helper scans the jsonnet for overrides.<path> references (skipping // comments). The new test keys_to_be_replaced_are_covered_by_override_schema checks that every KEYS_TO_BE_REPLACED entry has exactly one matching override prefix, and that every jsonnet override path maps to some replacer key—failing with actionable messages for uncovered, ambiguous, or stray override refs.

Reviewed by Cursor Bugbot for commit 9872396. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 9fe115f to f4a4329 Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 69cf6dd to 4824f43 Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from f4a4329 to f93d240 Compare June 17, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants