Skip to content

apollo_deployments: assemble and deserialize node config from jsonnet#14487

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/build-node-configfrom
nimrod/jsonnet/node-config-deserialization
Open

apollo_deployments: assemble and deserialize node config from jsonnet#14487
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/build-node-configfrom
nimrod/jsonnet/node-config-deserialization

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from c0fb701 to 7bad5be Compare June 14, 2026 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch 2 times, most recently from 46c12a4 to d165f28 Compare June 14, 2026 12:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch 2 times, most recently from 2e5bbec to dca1eac Compare June 14, 2026 14:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from 084b1f4 to d011a46 Compare June 15, 2026 05:48
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch 2 times, most recently from c7ee7a9 to 78fbd17 Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from d011a46 to 78ce95e Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from 78fbd17 to f226a9e Compare June 16, 2026 08:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch 2 times, most recently from eec796a to 50b7e9b Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from f226a9e to 10d15a2 Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware self-assigned this Jun 16, 2026
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from 10d15a2 to 586dc1b Compare June 17, 2026 12:07
Comment thread crates/apollo_deployments/src/jsonnet.rs

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b105350. Configure here.

Comment thread crates/apollo_deployments/src/jsonnet.rs

@nimrod-starkware nimrod-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on dan-starkware).


crates/apollo_deployments/src/jsonnet.rs line 97 at r3 (raw file):

    for (service_name, config) in services {
        serde_json::from_value::<SequencerNodeConfig>(config.clone()).unwrap_or_else(|error| {

remove clone

Code quote:

config.clone()

@nimrod-starkware nimrod-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on dan-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants