apollo_deployments: assemble and deserialize node config from jsonnet#14487
apollo_deployments: assemble and deserialize node config from jsonnet#14487nimrod-starkware wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c0fb701 to
7bad5be
Compare
46c12a4 to
d165f28
Compare
2e5bbec to
dca1eac
Compare
084b1f4 to
d011a46
Compare
c7ee7a9 to
78fbd17
Compare
d011a46 to
78ce95e
Compare
78fbd17 to
f226a9e
Compare
eec796a to
50b7e9b
Compare
f226a9e to
10d15a2
Compare
10d15a2 to
586dc1b
Compare
c95bc3b to
cfd560c
Compare
586dc1b to
b105350
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b105350. Configure here.
cfd560c to
9ed7228
Compare
b105350 to
3727065
Compare
9ed7228 to
916f8fc
Compare
3727065 to
13f4f9b
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on dan-starkware).
crates/apollo_deployments/src/jsonnet.rs line 97 at r3 (raw file):
for (service_name, config) in services { serde_json::from_value::<SequencerNodeConfig>(config.clone()).unwrap_or_else(|error| {
remove clone
Code quote:
config.clone()
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on dan-starkware).
916f8fc to
5fb8ed5
Compare
13f4f9b to
ed6b542
Compare


No description provided.