Skip to content

apollo_deployments: assemble full node config via build.libsonnet#14486

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/distributed-layoutfrom
nimrod/jsonnet/build-node-config
Open

apollo_deployments: assemble full node config via build.libsonnet#14486
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/distributed-layoutfrom
nimrod/jsonnet/build-node-config

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

No description provided.

nimrod-starkware commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/distributed-layout branch from 5d9c58d to b5cb69f Compare June 14, 2026 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch 2 times, most recently from 46c12a4 to d165f28 Compare June 14, 2026 12:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/distributed-layout branch 2 times, most recently from 6b17b75 to 7bd0748 Compare June 14, 2026 14:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from d165f28 to 084b1f4 Compare June 14, 2026 14:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from 084b1f4 to d011a46 Compare June 15, 2026 05:48
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/distributed-layout branch 2 times, most recently from d7fb434 to f38d483 Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from d011a46 to 78ce95e Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from 78ce95e to eec796a Compare June 16, 2026 08:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/distributed-layout branch from f38d483 to bc8497a Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from eec796a to 50b7e9b Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware self-assigned this Jun 16, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 16, 2026 12:10
@cursor

cursor Bot commented Jun 16, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Deployment config assembly affects which components and L1 settings each node gets; mistakes could misconfigure production layouts, though layout names are asserted and logic is declarative.

Overview
Adds build.libsonnet, a top-level Jsonnet entry that assembles a full deployment layout into per-service SequencerNodeConfig objects via build(layoutName, overrides).

For each service in a layout (consolidated, hybrid, or distributed), it merges applicative config (only the *_config blocks for components that service runs), optional base_layer_config when L1 scrapers run there, shared monitoring_config, infra-derived components from derive.componentsFor, and a fixed validation_only: false.

Reviewed by Cursor Bugbot for commit 916f8fc. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/build-node-config branch from 9ed7228 to 916f8fc Compare June 21, 2026 12:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/distributed-layout branch from 6fba7e8 to 32f8e6c Compare June 21, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants