chore(api): remove dead bundle module and CAS read endpoint#1330
Open
jwiegley wants to merge 1 commit into
Open
chore(api): remove dead bundle module and CAS read endpoint#1330jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
2 times, most recently
from
b441368 to
7b0fed0
Compare
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
3 times, most recently
from
1f6cf1a to
2232155
Compare
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
2 times, most recently
from
350a8e7 to
bf56a32
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🚩 Bundle-related code in diff.rs remains after bundle module removal
The removed bundle.rs module and associated types are cleanly dead code, but src/commands/diff.rs:2140-2189 still contains a section titled "Filtered Diff for Bundle Sharing" with DiffOptions and get_diff_json_filtered. These don't depend on any removed types (they use DiffJson, not BundleData/CreateBundleRequest), so there's no breakage. However, if the intent is to fully remove bundle support, this code may be orphaned as well — worth checking if get_diff_json_filtered and DiffOptions have any remaining callers.
Was this helpful? React with 👍 or 👎 to provide feedback.
ApiClient::create_bundle (api/bundle.rs) and ApiClient::read_ca_prompt_store (api/cas.rs) were never called from any production code path or test. Remove both implementations along with the types they exclusively required (BundleData, CreateBundleRequest, CreateBundleResponse, CasMessagesObject, CAPromptStoreReadResult, CAPromptStoreReadResponse) and their unit tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
from
bf56a32 to
a8e9995
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/api/bundle.rsentirely —ApiClient::create_bundlewas never called from any production code path or testApiClient::read_ca_prompt_storefromsrc/api/cas.rs— zero callersBundleData,CreateBundleRequest,CreateBundleResponse,CasMessagesObject,CAPromptStoreReadResult,CAPromptStoreReadResponseTest plan
task buildpassestask lintpassesgrep -rn "create_bundle\|BundleData\|CreateBundleRequest\|read_ca_prompt_store\|CAPromptStore\|CasMessages" src/ tests/returns zero hits🤖 Generated with Claude Code