Skip to content

chore: strip stale #[allow(dead_code)] from live functions#1340

Open
jwiegley wants to merge 1 commit into
dc/auth-config-mdm-cleanupfrom
dc/stale-annotations-cleanup
Open

chore: strip stale #[allow(dead_code)] from live functions#1340
jwiegley wants to merge 1 commit into
dc/auth-config-mdm-cleanupfrom
dc/stale-annotations-cleanup

Conversation

@jwiegley

@jwiegley jwiegley commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary

These suppressions were correct when added but became stale as callers were added or tests were written. Affects: log_message, with_warning, notes_add_blob_batch, get_reference_as_working_log, persist_file_version, Blob::id, remote_head, push_authorship, get_file_content, from_bare_repository, CiContext::with_repository, AttributionTracker::with_config.

Test plan

  • task build passes
  • task lint passes

🤖 Generated with Claude Code


Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@jwiegley jwiegley requested review from heapwolf and svarlamov May 11, 2026 20:52
@jwiegley jwiegley force-pushed the dc/auth-config-mdm-cleanup branch from 7fdd403 to 9147d02 Compare May 13, 2026 18:03
@jwiegley jwiegley force-pushed the dc/stale-annotations-cleanup branch from 4b5f4e9 to 2a3ff6e Compare May 13, 2026 18:03
@jwiegley jwiegley force-pushed the dc/auth-config-mdm-cleanup branch from 9147d02 to 8780647 Compare May 19, 2026 22:24
@jwiegley jwiegley force-pushed the dc/stale-annotations-cleanup branch 2 times, most recently from 5166dbc to bc3f93c Compare May 26, 2026 17:19
@jwiegley jwiegley force-pushed the dc/stale-annotations-cleanup branch from bc3f93c to 8e9d328 Compare May 28, 2026 18:13
@jwiegley jwiegley force-pushed the dc/auth-config-mdm-cleanup branch 2 times, most recently from a085b70 to 32eb469 Compare June 1, 2026 18:30
@jwiegley jwiegley force-pushed the dc/stale-annotations-cleanup branch from 8e9d328 to 31bef48 Compare June 1, 2026 18:30
@jwiegley jwiegley force-pushed the dc/auth-config-mdm-cleanup branch from 32eb469 to c46f342 Compare June 8, 2026 17:56
@jwiegley jwiegley force-pushed the dc/stale-annotations-cleanup branch from 31bef48 to 80f89b0 Compare June 8, 2026 17:56
These suppressions were correct when originally added but became stale
as call sites were added or tests were written. The functions they cover
are now reachable: log_message (bash_tool, git_ai_handlers, upgrade),
with_warning (install_hooks tests), notes_add_blob_batch and
get_reference_as_working_log (refs_unit tests), persist_file_version
(repo_storage_unit tests), Blob::id and remote_head and push_authorship
and get_file_content and from_bare_repository (repository callers),
CiContext::with_repository (ci_context_unit tests), and
AttributionTracker::with_config (attribution_tracker tests).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jwiegley jwiegley force-pushed the dc/stale-annotations-cleanup branch from 80f89b0 to b6e3aa4 Compare June 9, 2026 16:36
@jwiegley jwiegley force-pushed the dc/auth-config-mdm-cleanup branch from c46f342 to 3d55c11 Compare June 9, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant