chore(git): remove dead RewriteLogEvent factories and orphaned constructors#1335
Open
jwiegley wants to merge 1 commit into
Open
chore(git): remove dead RewriteLogEvent factories and orphaned constructors#1335jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
This was referenced May 11, 2026
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
67ffe40 to
dc439a7
Compare
jwiegley
force-pushed
the
dc/git-rewrite-log-cleanup
branch
from
0dd3d00 to
580dd2c
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
dc439a7 to
7845736
Compare
jwiegley
force-pushed
the
dc/git-rewrite-log-cleanup
branch
from
580dd2c to
27302e2
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
7845736 to
f1f74c3
Compare
jwiegley
force-pushed
the
dc/git-rewrite-log-cleanup
branch
from
27302e2 to
613436b
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
f1f74c3 to
cc52733
Compare
jwiegley
force-pushed
the
dc/git-rewrite-log-cleanup
branch
from
613436b to
1db811d
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
cc52733 to
f5ad53c
Compare
jwiegley
force-pushed
the
dc/git-rewrite-log-cleanup
branch
from
1db811d to
8a9c5f3
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
f5ad53c to
e75f51e
Compare
jwiegley
force-pushed
the
dc/git-rewrite-log-cleanup
branch
from
8a9c5f3 to
3733b1b
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…uctors RewriteLogEvent::revert_mixed and authorship_logs_synced were factory functions with zero callers — the corresponding enum variants are retained for serde deserialization of persisted rewrite logs. With those factories gone, RebaseStartEvent::new, RevertMixedEvent::new, and AuthorshipLogsSyncedEvent::new became orphaned constructors with no remaining callers; remove them too. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/git-rewrite-log-cleanup
branch
from
3733b1b to
6bdf5c8
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
e75f51e to
96fb3fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RewriteLogEvent::revert_mixed and authorship_logs_synced were factory functions with zero callers. The corresponding enum variants are retained for serde deserialization of persisted rewrite logs. With those factories gone, RebaseStartEvent::new, RevertMixedEvent::new, and AuthorshipLogsSyncedEvent::new became orphaned constructors — remove them too.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code